chore: bump dev version to 3.1.0-alpha.0#441
Merged
oleonardolima merged 2 commits intobitcoindevkit:masterfrom Apr 27, 2026
Merged
chore: bump dev version to 3.1.0-alpha.0#441oleonardolima merged 2 commits intobitcoindevkit:masterfrom
oleonardolima merged 2 commits intobitcoindevkit:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #441 +/- ##
=======================================
Coverage 80.21% 80.21%
=======================================
Files 24 24
Lines 5348 5348
Branches 242 242
=======================================
Hits 4290 4290
Misses 980 980
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ValuedMammal
force-pushed
the
chore/bump_dev_3_1_0
branch
from
c402a7a to
794a80b
Compare
110CodingP
approved these changes
Apr 27, 2026
Collaborator
110CodingP
left a comment
110CodingP
left a comment
There was a problem hiding this comment.
Should we remove _tx_amounts from the test completely? It was introduced in b4c31cd to calculate the sent and received amounts but this is already done by Wallet::sent_and_received so was removed in 0362998. We could also use the amounts given by tx_amounts in the asserts statements instead of the hardcoded values.
Clean up unused code in `test_get_funded_wallet_sent_and_received`.
ValuedMammal
force-pushed
the
chore/bump_dev_3_1_0
branch
from
794a80b to
c55875d
Compare
Member
|
ACK c55875d. |
3 tasks
ValuedMammal
added a commit
that referenced
this pull request
Apr 28, 2026
d3fe261 fix(ci): pin `idna_adapter` to `1.2.1` (Leonardo Lima) Pull request description: ### Description It fixes the MSRV CI by pining `idna_adapter`. ### Notes to the reviewers I noticed it's broken after merging #441, this PR should fix it. ### Changelog notice ``` ### Changed - fix(ci): pin `idna_adapter` to `1.2.1` ``` ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `just p` before pushing ACKs for top commit: luisschwab: ACK d3fe261 Tree-SHA512: 92526486fd4719715e8a63eed007701094d5369afa51b98ebf5d5f98a3c043c9360b9f8ac82c234bbed402e4b89d53a8c49dd523b8663d4033bf6067179f13a5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps the package version in
Cargo.tomlfrom3.0.0to3.1.0-alpha.0following the coding conventions outlined in #19. Also bump toolchain channel to 1.95.0 inrust-toolchain.toml.Checklists
All Submissions:
just pbefore pushing