fix(descriptor): correct variable binding names in l: and u: fragment modifiers#454
Merged
ValuedMammal merged 1 commit intobitcoindevkit:masterfrom Apr 24, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #454 +/- ##
=======================================
Coverage 80.21% 80.21%
=======================================
Files 24 24
Lines 5348 5348
Branches 242 242
=======================================
Hits 4290 4290
Misses 980 980
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ment modifiers The `l:` arm bound `a_networks_kinds` but referenced `a_network_kinds`, and the `u:` arm bound `a_networks` but referenced `a_network_kinds`. Both closures silently captured the wrong variable from an outer scope, which could produce incorrect network kind filtering results. Co-Authored-By: HAL 9000 Signed-off-by: Elias Rohrer <dev@tnull.de>
Collaborator
|
Thank you HAL. ACK 5d158a4; ran the tests locally |
ValuedMammal
force-pushed
the
2026-04-fix-dsl-modifier-typos
branch
from
fccb950 to
5d158a4
Compare
ValuedMammal
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
l:arm bounda_networks_kindsbut referenceda_network_kinds, and theu:arm bounda_networksbut referenceda_network_kinds. Both closures silently captured the wrong variable from an outer scope, which could produce incorrect network kind filtering results.Checklists
All Submissions:
just pbefore pushingBugfixes: