fix(descriptor): reject bare descriptors in check_wallet_descriptor#457
Open
tharu-jwd wants to merge 1 commit intobitcoindevkit:masterfrom
Open
fix(descriptor): reject bare descriptors in check_wallet_descriptor#457tharu-jwd wants to merge 1 commit intobitcoindevkit:masterfrom
tharu-jwd wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
Collaborator
|
Would you mind dropping 33fb97b and push this again with just the bare descriptor check fix, thank you. |
Author
Hey, sure. |
Bare descriptors (e.g. pk()) have no standard address form. Passing one to the wallet would not be caught at creation time and would cause panics later when address derivation is attempted. Add an UnsupportedDescriptorType variant to DescriptorError and check for DescriptorType::Bare in check_wallet_descriptor, returning the new error before the descriptor reaches wallet internals. Closes bitcoindevkit#54
tharu-jwd
force-pushed
the
fix/reject-bare-descriptors
branch
from
7987a55 to
15604e8
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #457 +/- ##
==========================================
- Coverage 80.21% 80.19% -0.02%
==========================================
Files 24 24
Lines 5348 5353 +5
Branches 242 243 +1
==========================================
+ Hits 4290 4293 +3
- Misses 980 982 +2
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bare descriptors (e.g.
pk()) have no standard address form. Passing one to the wallet wasn't caught at creation time, causing panics later when address derivation is attempted. Closes #54.Adds
UnsupportedDescriptorTypetoDescriptorErrorand checks forDescriptorType::Bareincheck_wallet_descriptor, returning the new error before the descriptor reaches wallet internals.Checklist
All Submissions:
cargo fmtandcargo clippybefore committingBugfixes: