fix: handle MultiXPrv/MultiXPub in network kind detection and fixup#459
Open
tnull wants to merge 1 commit intobitcoindevkit:masterfrom
Open
fix: handle MultiXPrv/MultiXPub in network kind detection and fixup#459tnull wants to merge 1 commit intobitcoindevkit:masterfrom
tnull wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
The IntoDescriptorKey impl for DescriptorSecretKey was missing a MultiXPrv match arm, causing mainnet MultiXPrv keys to fall through to the catch-all and receive test_network_kind() instead of mainnet_network_kind(). Also add MultiXPub/MultiXPrv handling to the network fixup code in descriptor/mod.rs, which previously only fixed up XPub/XPrv pairs. Co-Authored-By: HAL 9000 Signed-off-by: Elias Rohrer <dev@tnull.de>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #459 +/- ##
==========================================
+ Coverage 80.04% 80.05% +0.01%
==========================================
Files 24 24
Lines 5336 5361 +25
Branches 242 243 +1
==========================================
+ Hits 4271 4292 +21
- Misses 987 990 +3
- Partials 78 79 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ValuedMammal
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The IntoDescriptorKey impl for DescriptorSecretKey was missing a MultiXPrv match arm, causing mainnet MultiXPrv keys to fall through to the catch-all and receive test_network_kind() instead of mainnet_network_kind().
Also add MultiXPub/MultiXPrv handling to the network fixup code in descriptor/mod.rs, which previously only fixed up XPub/XPrv pairs.
Checklists
All Submissions:
just pbefore pushingBugfixes: