Skip to content

fix(ci): pin idna_adapter to 1.2.1#466

Merged
ValuedMammal merged 1 commit intobitcoindevkit:masterfrom
oleonardolima:ci/pin-idna-adapter-to-1.2.1
Apr 28, 2026
Merged

fix(ci): pin idna_adapter to 1.2.1#466
ValuedMammal merged 1 commit intobitcoindevkit:masterfrom
oleonardolima:ci/pin-idna-adapter-to-1.2.1

Conversation

@oleonardolima
Copy link
Copy Markdown
Contributor

Description

It fixes the MSRV CI by pining idna_adapter.

Notes to the reviewers

I noticed it's broken after merging #441, this PR should fix it.

Changelog notice


### Changed
- fix(ci): pin `idna_adapter` to `1.2.1`

Checklists

All Submissions:

@oleonardolima oleonardolima added this to the Wallet 3.1.0 milestone Apr 27, 2026
@oleonardolima oleonardolima self-assigned this Apr 27, 2026
@oleonardolima oleonardolima added github_actions Pull requests that update GitHub Actions code chore Non-coding related work labels Apr 27, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.21%. Comparing base (6ec0146) to head (d3fe261).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #466   +/-   ##
=======================================
  Coverage   80.21%   80.21%           
=======================================
  Files          24       24           
  Lines        5348     5348           
  Branches      242      242           
=======================================
  Hits         4290     4290           
  Misses        980      980           
  Partials       78       78           
Flag Coverage Δ
rust 80.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oleonardolima oleonardolima marked this pull request as ready for review April 27, 2026 19:23
@oleonardolima oleonardolima moved this to Needs Review in BDK Wallet Apr 27, 2026
Copy link
Copy Markdown
Member

@luisschwab luisschwab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d3fe261

@ValuedMammal ValuedMammal merged commit db1eab4 into bitcoindevkit:master Apr 28, 2026
18 checks passed
@oleonardolima oleonardolima deleted the ci/pin-idna-adapter-to-1.2.1 branch April 28, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Non-coding related work github_actions Pull requests that update GitHub Actions code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants