Skip to content

fix!: change auth_delay to return u8#64

Merged
notmandatory merged 1 commit intomasterfrom
fix/auth_delay_u8
Apr 7, 2026
Merged

fix!: change auth_delay to return u8#64
notmandatory merged 1 commit intomasterfrom
fix/auth_delay_u8

Conversation

@notmandatory
Copy link
Copy Markdown
Member

@notmandatory notmandatory commented Apr 7, 2026

Description

Changes the return value for auth_delay from a usize to a u8. The value will never be more than 15 so a u8 is more appropriate and can be cleanly exposed via FFI.

Notes to the reviewers

This is an API BREAKING change.

I manually tested this change with physical TAPSIGNER, SATSCARD, and SATSCHIP cards via the CLI.

I also removed an unneeded ref return from auth_delay since the type Option<u8> implements the Copy trait.

Changelog notice

  • Change return type of auth_delay from a usize to a u8. API BREAKING.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@notmandatory notmandatory self-assigned this Apr 7, 2026
@notmandatory notmandatory requested a review from reez as a code owner April 7, 2026 17:52
Copy link
Copy Markdown
Collaborator

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e0afe8c

This is a good change. Clippy failures is all that's blocking merge I think, but merge whenever you're ready

@notmandatory notmandatory merged commit 257ac57 into master Apr 7, 2026
11 checks passed
@notmandatory notmandatory deleted the fix/auth_delay_u8 branch April 7, 2026 21:34
@notmandatory notmandatory added this to the Release 0.3.0 milestone Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants