Increase the ChangeError len values to u32#66
Merged
notmandatory merged 1 commit intomasterfrom Apr 8, 2026
Merged
Conversation
BREAKING CHANGE.
reez
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue mentioned in #65 (comment).
I confirmed that if a too long CVC is used then an incorrect
lenvalue is returned. After the fix in this PR any CVC less than 2^32 in length will return an error with the actual inputted incorrect CVC length.Notes to the reviewers
I tested before and after this change with the cli tool and an emulated TAPSIGNER card.
This is a BREAKING CHANGE.
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: