Skip to content

Increase the ChangeError len values to u32#66

Merged
notmandatory merged 1 commit intomasterfrom
fix/change_err
Apr 8, 2026
Merged

Increase the ChangeError len values to u32#66
notmandatory merged 1 commit intomasterfrom
fix/change_err

Conversation

@notmandatory
Copy link
Copy Markdown
Member

@notmandatory notmandatory commented Apr 8, 2026

Description

Fixes issue mentioned in #65 (comment).

I confirmed that if a too long CVC is used then an incorrect len value is returned. After the fix in this PR any CVC less than 2^32 in length will return an error with the actual inputted incorrect CVC length.

Notes to the reviewers

I tested before and after this change with the cli tool and an emulated TAPSIGNER card.

This is a BREAKING CHANGE.

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@notmandatory notmandatory requested a review from reez as a code owner April 8, 2026 18:54
@notmandatory notmandatory self-assigned this Apr 8, 2026
@notmandatory notmandatory added the bug Something isn't working label Apr 8, 2026
Copy link
Copy Markdown
Collaborator

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 891de46

LGTM!

@notmandatory notmandatory merged commit 891de46 into master Apr 8, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants