Include latest error in AllAttemptsErrored

  $ git grep AllAttemptsErrored
  src/client.rs:                        return Err(Error::AllAttemptsErrored(errors));
  src/client.rs:                                        return Err(Error::AllAttemptsErrored(errors));
fixed here
  src/raw_client.rs:    Err(Error::AllAttemptsErrored(errors))
already correctly collected
  src/types.rs:    AllAttemptsErrored(Vec<Error>),
  src/types.rs:            Error::AllAttemptsErrored(errors) => {
consumers

This also reorders the warning before the error:
  warn!("re-creating client failed with {}, retry: {}/{}", e, failed_attempts, $self.config.retry());
  warn!("re-creating client failed after {} attempts", failed_attempts);

Closes #186

Author: nabijaczleweli

src/client.rs

@@ -55,15 +55,15 @@ macro_rules! impl_inner_call {
                 Err(e) => {
                     let failed_attempts = errors.len() + 1;
 
+                    warn!("call '{}' failed with {}, retry: {}/{}", stringify!($name), e, failed_attempts, $self.config.retry());
+
+                    errors.push(e);
+
                     if retries_exhausted(failed_attempts, $self.config.retry()) {
                         warn!("call '{}' failed after {} attempts", stringify!($name), failed_attempts);
                         return Err(Error::AllAttemptsErrored(errors));
                     }
 
-                    warn!("call '{}' failed with {}, retry: {}/{}", stringify!($name), e, failed_attempts, $self.config.retry());
-
-                    errors.push(e);
-
                     // Only one thread will try to recreate the client getting the write lock,
                     // other eventual threads will get Err and will block at the beginning of
                     // previous loop when trying to read()
@@ -79,14 +79,14 @@ macro_rules! impl_inner_call {
                                 Err(e) => {
                                     let failed_attempts = errors.len() + 1;
 
+                                    warn!("re-creating client failed with {}, retry: {}/{}", e, failed_attempts, $self.config.retry());
+
+                                    errors.push(e);
+
                                     if retries_exhausted(failed_attempts, $self.config.retry()) {
                                         warn!("re-creating client failed after {} attempts", failed_attempts);
                                         return Err(Error::AllAttemptsErrored(errors));
                                     }
-
-                                    warn!("re-creating client failed with {}, retry: {}/{}", e, failed_attempts, $self.config.retry());
-
-                                    errors.push(e);
                                 }
                             }
                         }