Merge #176: Roll a custom TestEnv and drop lazy_static

5748132 refactor(test): properly assert for HTTP headers (Leonardo Lima)
ed9d7ad feat(test): roll a custom `TestEnv` and drop `lazy_static` (Luis Schwab)
b6bb968 chore(ci): fix pinning for 1.75.0 MSRV (Luis Schwab)

Pull request description:

  Closes #149

  Implement a custom `TestEnv`, which is instantiated per-test and fixes the un-dropped `bitcoind` issue. This also allows running tests with more than 1 thread, since they no longer share `bitcoind` and `electrsd` instances.

  Also adds helpers to fetch externally sourced addresses, fixing the issue where `bitcoind`'s wallet would send change outputs to it's own wallet address, which would mess with `test_get_scripthash_stats`.

  The `test` recipe and CI job are updated to now use 16 threads.

ACKs for top commit:
  oleonardolima:
    ACK 5748132

Tree-SHA512: 5143abc8ef5835755aff6e234caac2214d1af6f20743af3f8eb2fbc0ab3a7a34b6b675a9a7850ab804bdd2f8b1e0673319cfe17063a60334fcca45e5de67c203

Author: luisschwab

.github/workflows/cont_integration.yml

@@ -53,7 +53,7 @@ jobs:
     - name: Build
       run: cargo build --features ${{ matrix.features }} --no-default-features
     - name: Test
-      run: cargo test --features ${{ matrix.features }} --no-default-features -- --test-threads=1
+      run: cargo test --features ${{ matrix.features }} --no-default-features -- --test-threads=16
 
   fmt:
     name: Rust Formatting

Cargo.toml

@@ -34,7 +34,6 @@ tokio = { version = "1", features = ["time"], optional = true }
 [dev-dependencies]
 tokio = { version = "1.20.1", features = ["full"] }
 electrsd = { version = "0.36.1", features = ["legacy", "esplora_a33e97e1", "corepc-node_29_0"] }
-lazy_static = "1.4.0"
 
 [features]
 default = ["blocking", "async", "async-https", "tokio"]

ci/pin-msrv.sh

@@ -5,7 +5,7 @@ set -euo pipefail
 
 # Pin dependencies for MSRV (1.75.0)
 cargo update -p minreq --precise "2.13.2"
-cargo update -p idna_adapter --precise "1.2.0"
 cargo update -p native-tls --precise "0.2.13"
+cargo update -p idna_adapter --precise "1.2.0"
 cargo update -p zerofrom --precise "0.1.5"
 cargo update -p litemap --precise "0.7.4"

justfile

@@ -28,13 +28,14 @@ fmt:
 
 # Build and test using the MSRV toolchain (1.75.0)
 msrv:
-    bash ci/pin-msrv.sh
-    cargo +1.75.0 build --all-features
-    cargo +1.75.0 test --all-features -- --test-threads=1
+   rm -rf Cargo.lock
+   bash ci/pin-msrv.sh
+   cargo +1.75.0 build --all-features
+   cargo +1.75.0 test --all-features -- --test-threads=16
 
 # Run pre-push suite: format, check, and test
-pre-push: fmt check test
+pre-push: fmt check test msrv
 
 # Run all tests on the workspace with all features
 test:
-   cargo test --all-features -- --test-threads=1
+   cargo test --all-features -- --test-threads=16