Remove `BlockSummary` in favor of `BlockInfo`

[luisschwab]

This is the current BlockSummary struct, and the response from blockstream.info:

#[derive(Deserialize, Clone, Debug, PartialEq, Eq)]
pub struct BlockTime {
    pub timestamp: u64,
    pub height: u32,
}

#[derive(Debug, Clone, Deserialize, PartialEq, Eq)]
pub struct BlockSummary {
    pub id: BlockHash,
    #[serde(flatten)]
    pub time: BlockTime,
    /// Hash of the previous block, will be `None` for the genesis block.
    pub previousblockhash: Option<bitcoin::BlockHash>,
    pub merkle_root: bitcoin::hash_types::TxMerkleNode,
}

{
  "id": "000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f",
  "height": 0,
  "version": 1,
  "timestamp": 1231006505,
  "tx_count": 1,
  "size": 285,
  "weight": 1140,
  "merkle_root": "4a5e1e4baab89f3a32518a88c31bc87f618f76673e2cc77ab2127b7afdeda33b",
  "previousblockhash": null,
  "mediantime": 1231006505,
  "nonce": 2083236893,
  "bits": 486604799,
  "difficulty": 1.0
}

[luisschwab]

It looks like get_blocks should also be returning BlockInfo:

curl "https://blockstream.info/api/block/000000000000000000015d734e693919865164d869a40523d021372c17e879a0" | jq
{
  "id": "000000000000000000015d734e693919865164d869a40523d021372c17e879a0",
  "height": 927308,
  "version": 539312128,
  "timestamp": 1765394257,
  "tx_count": 3362,
  "size": 1581734,
  "weight": 3993812,
  "merkle_root": "99a6a4821fe9d8f9c582d2bcfe578ac5c27adfe100cd54caf87aed0cf7cc9844",
  "previousblockhash": "00000000000000000001a41e2b92bd8b99e0dc0b9d63c5ab093fb920252bd3fe",
  "mediantime": 1765392395,
  "nonce": 2158905818,
  "bits": 385999520,
  "difficulty": 149301205959699.9
}

curl "https://blockstream.info/api/blocks" | jq
[
  {
    "id": "000000000000000000012f451e789a45c68f5794dd4fc899fbd7e8d1e75de255",
    "height": 927309,
    "version": 684924928,
    "timestamp": 1765394529,
    "tx_count": 1400,
    "size": 578791,
    "weight": 1460995,
    "merkle_root": "30965c9b9b963a5133fc7bb9b08d73865c720d53ff246fc0d68c547c2c6b2a36",
    "previousblockhash": "000000000000000000015d734e693919865164d869a40523d021372c17e879a0",
    "mediantime": 1765392439,
    "nonce": 2430912203,
    "bits": 385999520,
    "difficulty": 149301205959699.9
  },
  ...
]

[ValuedMammal]

IMO it will be less disruptive downstream to write a new function that returns BlockInfos and deprecate the old.

[luisschwab]

Makes sense @ValuedMammal I'll make a PR that deprecates the old and adds the new, then we can make another minor release. After that, remove the old and release v13.0.0. cc @oleonardolima

[luisschwab]

Actually we can't do it this way, since the MSRV has already been bumped. We can remove the deprecated when we release v14.

[oleonardolima]

Actually we can't do it this way, since the MSRV has already been bumped. We can remove the deprecated when we release v14.

We can still do another minor release, it's just a matter of creating another branch (eg. release/0.12.x) and do it there if you think that's better than wait another release cycle.

[luisschwab]

We can still do another minor release, it's just a matter of creating another branch (eg. release/0.12.x) and do it there if you think that's better than wait another release cycle.

Sounds good. Let me know when you create it.

[oleonardolima]

We can still do another minor release, it's just a matter of creating another branch (eg. release/0.12.x) and do it there if you think that's better than wait another release cycle.

Sounds good. Let me know when you create it.

You can open the PR now, it's created https://github.com/bitcoindevkit/rust-esplora-client/tree/release/0.12.x