ci,msrv: pin tracing-core to 0.1.33#130
Merged
notmandatory merged 2 commits intobitcoindevkit:masterfrom Jun 27, 2025
Merged
Conversation
- pin `parking_lot` to 0.12.3 - pin `parking_lot_core` to 0.9.10 - pin `lock_api` to 0.4.12
Pull Request Test Coverage Report for Build 15916690381Details
💛 - Coveralls |
118279d to
fd5857e
Compare
This became a warning in rust 1.88.0 https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
notmandatory
approved these changes
Jun 27, 2025
Member
There was a problem hiding this comment.
tACK 3178d17
I wasn't able to find any new pinned deps that aren't needed.
I had to fix new rust 1.88 clippy warnings.
chrono-raven6i90
added a commit
to chrono-raven6i90/rust-esplora-client
that referenced
this pull request
Oct 28, 2025
…re` to 0.1.33
3178d1734f85523353bf78e690aef9aceb091124 ci: fix new clippy uninlined_format_args warning (Steve Myers)
fd5857e9cb9baf9a2a99ed7e0a917e2deb0a7887 ci,msrv: pin `tracing-core` to 0.1.33 (valued mammal)
Pull request description:
PR updates the pinned dependencies to build on MSRV. Opening this to test out the changes in CI.
- pin `tracing-core` to 0.1.33
- pin `parking_lot` to 0.12.3
- pin `parking_lot_core` to 0.9.10
- pin `lock_api` to 0.4.12
ACKs for top commit:
notmandatory:
tACK 3178d1734f85523353bf78e690aef9aceb091124
Tree-SHA512: 45437008408201606da88a664ab33cb30df6e3ba2d03ec77e7c914bc527fc7cace9922f8e484467b89e9950cc3796bdea8581870af38c574da61ee23050f0a81
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR updates the pinned dependencies to build on MSRV. Opening this to test out the changes in CI.
tracing-coreto 0.1.33parking_lotto 0.12.3parking_lot_coreto 0.9.10lock_apito 0.4.12