Serde_Json error variant#163
Closed
AayushGupta56 wants to merge 2 commits intobitcoindevkit:masterfrom
Closed
Conversation
tnull
reviewed
Jan 23, 2026
Contributor
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Could you give some context on when/how you encountered this?
| Minreq(::minreq::Error), | ||
| /// Error during reqwest HTTP request | ||
| #[cfg(feature = "async")] | ||
| #[cfg(feature = "reqwest")] |
Collaborator
There was a problem hiding this comment.
why did you change this ?
Author
There was a problem hiding this comment.
I guess I did it by mistake, I was just trying something but it didn't worked and I forgot to change it.
Collaborator
In #161 we're looking forward to remove some of the existing |
Member
|
Overridden by #171. |
oleonardolima
added a commit
that referenced
this pull request
Feb 12, 2026
…mit_package` d651e71 chore(client): remove `serde_json` unwraps in favor of `Error::SerdeJson` (Luis Schwab) d7cd704 feat(lib)!: add `Error::SerdeJson` variant (Luis Schwab) d6a07af chore(deps): bump `electrsd` to v0.36.1 (Luis Schwab) 31a8dc4 chore(ci): fix pins for 1.75.0 MSRV (Luis Schwab) Pull request description: Closes #161. Replaces #163. This PR adds a new error variant for `serde_json` and removes the lingering unwraps on the `submit_package` methods. ### Changelog Notice ``` # Added - New `Error::SerdeJson` error variant ``` Also bumps `electrsd` to v0.36.1 and fixes MSRV dependency pinning. ACKs for top commit: oleonardolima: ACK d651e71 Tree-SHA512: b011e2bb3fba5eb05ba08c6349c39acef680f29524e6142bb392ecd2257bc51384ccd8a4b98021ee4d24ed26ea99c6857771bd1c57a0c2ca3481ffdd3eebd939
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #161
This PR replaces .unwrap_or_default() with proper error propagation in submit_package for both blocking and async clients.