Implant cargo-rbmt#203
Merged
Merged
Conversation
- Define stable and nightly toolchain versions - Allow duplicates: `getrandom`, `windows-sys` and `wit-bindgen` - Remove unused `log` dependency - Resolve dependency versions to comply with MSRV - Define exact feature sets for running tests
oleonardolima
approved these changes
May 3, 2026
Collaborator
oleonardolima
left a comment
oleonardolima
left a comment
There was a problem hiding this comment.
utACK 8fc9273
I left a few comments that can be addressed in a follow-up.
| log = "^0.4" | ||
| bitreq = { version = "0.3.4", optional = true } | ||
| hex = { version = "0.2.2", package = "hex-conservative" } | ||
| bitreq = { version = "0.3.5", optional = true } |
Collaborator
There was a problem hiding this comment.
nit: now having another look at it it would be better to have both proxy and json-using-serde setup here, they're always being used.
Member
Author
There was a problem hiding this comment.
We can look into this in a follow up.
| alias a := audit | ||
| alias b := build | ||
| alias c := check | ||
| alias cs := check-sigs |
Collaborator
There was a problem hiding this comment.
nit: I'd suggest verify-sigs, it could be confused with cargo check one.
Collaborator
|
ping @luisschwab |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #178
This PR introduces
cargo-rbmtfor local and CI checking, linting, testing and lockfile generation.Changelog