Merge #68: Fix clippy 0.1.66

fbff967 ci: update build job and set rust stable to v1.66.1 (Yuki Kishimoto)
8321fc0 Fix clippy 0.1.66 (Yuki Kishimoto)

Pull request description:

ACKs for top commit:
  danielabrozzoni:
    utACK fbff967

Tree-SHA512: e3ba58584d4afc687e2a13ba3120a58fb2a17fe222801bfababf97cccbd912bec06efc157caf276f9fdf7a2576085f2e9c29191e1f1afbf1d184a514ea1b85af

Author: danielabrozzoni

.github/workflows/main.yml

@@ -19,33 +19,43 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-      - run: cargo build
-      - uses: actions-rs/clippy-check@v1
+      - name: Checkout
+        uses: actions/checkout@v3
+      - name: Cache
+        uses: actions/cache@v3
         with:
-          token: ${{ secrets.GITHUB_TOKEN }}
-          args: --all-features -- -D warnings
+          path: |
+            ~/.cargo/registry
+            ~/.cargo/git
+            target
+          key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.toml','**/Cargo.lock') }}
+      - name: Set profile
+        run: rustup set profile minimal && rustup component add clippy
+      - name: Build
+        run: cargo build
+      - name: Clippy
+        run: cargo clippy --all-features -- -D warnings
   test-emulators:
     runs-on: ubuntu-20.04
     strategy:
       matrix:
         rust:
-          - version: 1.61.0 # STABLE
+          - version: 1.66.1 # STABLE
           - version: 1.41.1 # MSRV
         emulator:
           - name: trezor
           - name: ledger
     steps:
       - name: Checkout
         uses: actions/checkout@v3
-      - name: cache
+      - name: Cache
         uses: actions/cache@v3
         with:
           path: |
             ~/.cargo/registry
             ~/.cargo/git
             target
-          key: ${{ runner.os }}-cargo-test-emulators-${{ hashFiles('**/Cargo.toml','**/Cargo.lock') }}
+          key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.toml','**/Cargo.lock') }}
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v2
       - name: Build and push

src/interface.rs

@@ -214,7 +214,7 @@ impl HWIClient {
         &self,
         psbt: &PartiallySignedTransaction,
     ) -> Result<HWIPartiallySignedTransaction, Error> {
-        let psbt = base64::encode(&serialize(psbt));
+        let psbt = base64::encode(serialize(psbt));
         Python::with_gil(|py| {
             let output = self
                 .hwilib

src/types.rs

@@ -35,7 +35,7 @@ pub struct HWISignature {
 
 fn from_b64<'de, D: Deserializer<'de>>(d: D) -> Result<Vec<u8>, D::Error> {
     let b64_string = String::deserialize(d)?;
-    base64::decode(&b64_string)
+    base64::decode(b64_string)
         .map_err(|_| serde::de::Error::custom("Error while Deserializing Signature"))
 }
 
@@ -62,7 +62,7 @@ fn deserialize_psbt<'de, D: Deserializer<'de>>(
     d: D,
 ) -> Result<PartiallySignedTransaction, D::Error> {
     let b64_string = String::deserialize(d)?;
-    let bytes = base64::decode(&b64_string).map_err(serde::de::Error::custom)?;
+    let bytes = base64::decode(b64_string).map_err(serde::de::Error::custom)?;
     bitcoin::consensus::deserialize::<PartiallySignedTransaction>(&bytes[..])
         .map_err(serde::de::Error::custom)
 }