Skip to content

Update GitHub Actions versions#2240

Open
PixelPil0t1 wants to merge 1 commit intobitcoinjs:masterfrom
PixelPil0t1:master
Open

Update GitHub Actions versions#2240
PixelPil0t1 wants to merge 1 commit intobitcoinjs:masterfrom
PixelPil0t1:master

Conversation

@PixelPil0t1
Copy link
Copy Markdown

Update GitHub Actions versions

@landabaso
Copy link
Copy Markdown
Member

Hey @junderw this looks good to me. It fixes the red CI runs (e.g. #2248 , #2247 ). I applied the same changes in my fork and the workflow went green: https://github.com/landabaso/bitcoinjs-lib/actions/runs/16500766519

main_ci.yml currently pins v2/v3 Actions to specific SHAs. Was there a particular reason (security/reproducibility)? If not, moving to the v4 tags (or pinning the latest v4 SHAs) seems fine. Once this merges, the failing workflows on master should pass again.

@junderw
Copy link
Copy Markdown
Member

junderw commented Jul 26, 2025

LGTM if we want to trust the repo maintainers of those actions.

Some users complained and I saw nothing wrong with pinning, so I allowed it.

This will probably upset those users.

I am indifferent.

@jasonandjay
Copy link
Copy Markdown
Member

Maintainer triage: this PR is pending re-validation against current master / v7 direction.

Please:

  1. rebase (or merge) latest master
  2. ensure full CI passes (format, lint, lint-tests, gitdiff, unit, integration, coverage, build-doc)
  3. confirm this PR still matches current roadmap/design assumptions

If there is no update in ~14 days, we may close this PR for backlog hygiene. You can always reopen or submit a refreshed PR later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants