fix(p2ms): fix signature validation bypass due to operator precedence#2333
Open
deepview-autofix wants to merge 1 commit intobitcoinjs:masterfrom
Open
fix(p2ms): fix signature validation bypass due to operator precedence#2333deepview-autofix wants to merge 1 commit intobitcoinjs:masterfrom
deepview-autofix wants to merge 1 commit intobitcoinjs:masterfrom
Conversation
The expression `(opts.allowIncomplete && x === OPS.OP_0) !== undefined` always evaluated to `true` when `allowIncomplete` was set, because `!== undefined` was applied to the boolean result of `&&` (which is never `undefined`). This caused `isAcceptableSignature()` to accept any arbitrary buffer as a valid signature when `allowIncomplete` was enabled, completely bypassing signature validation. Fixed by replacing `!== undefined` with `!!` to correctly coerce the result to boolean without altering the intended logic: accept only canonical script signatures or OP_0 placeholders (when allowIncomplete). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-Authored-By: DeepView Autofix <276251120+deepview-autofix@users.noreply.github.com> Co-Authored-By: Nikita Skovoroda <chalkerx@gmail.com> Signed-off-by: Nikita Skovoroda <chalkerx@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The expression
(opts.allowIncomplete && x === OPS.OP_0) !== undefinedalways evaluated to
truewhenallowIncompletewas set, because!== undefinedwas applied to the boolean result of&&(which isnever
undefined). This causedisAcceptableSignature()to accept anyarbitrary buffer as a valid signature when
allowIncompletewas enabled,completely bypassing signature validation.
Fixed by replacing
!== undefinedwith!!to correctly coerce theresult to boolean without altering the intended logic: accept only
canonical script signatures or OP_0 placeholders (when allowIncomplete).