fix(script_number): use arithmetic division instead of signed right shift in encode#2335
Open
deepview-autofix wants to merge 1 commit intobitcoinjs:masterfrom
Open
fix(script_number): use arithmetic division instead of signed right shift in encode#2335deepview-autofix wants to merge 1 commit intobitcoinjs:masterfrom
deepview-autofix wants to merge 1 commit intobitcoinjs:masterfrom
Conversation
…hift in encode Replace `value >>= 8` with `value = Math.floor(value / 256)` in the encode function. The signed right shift operator coerces its operand to a 32-bit signed integer via ToInt32, which truncates bits above bit 31. For 5-byte script numbers with values > 0xFFFFFFFF (e.g. 4294967296), this caused the upper byte information to be completely lost, producing incorrect encoded output. Math.floor(value / 256) works correctly for all safe JavaScript integer values. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-Authored-By: DeepView Autofix <276251120+deepview-autofix@users.noreply.github.com> Co-Authored-By: Nikita Skovoroda <chalkerx@gmail.com> Signed-off-by: Nikita Skovoroda <chalkerx@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
value >>= 8withvalue = Math.floor(value / 256)in the encode function. The signed right shift operator coerces its operand to a 32-bit signed integer via ToInt32, which truncates bits above bit 31.For 5-byte script numbers with values > 0xFFFFFFFF (e.g. 4294967296), this caused the upper byte information to be completely lost, producing incorrect encoded output.
Math.floor(value / 256) works correctly for all safe JavaScript integer values.