(chore) remove legacy fields from symbol_details

Author: vigan-abd

lib/symbol_details.js

@@ -19,12 +19,10 @@ class SymbolDetails extends Model {
   /**
    * @param {object|Array} data - symbol details data
    * @param {string} data.pair - pairs
-   * @param {string} data.pricePrecision - price precision
    * @param {number} data.initialMargin - inital margin
    * @param {number} data.minimumMargin - minimum margin
    * @param {string} data.maximumOrderSize - maximum order size
    * @param {string} data.minimumOrderSize - minimum order size
-   * @param {string} data.expiration - "N/A"
    * @param {boolean} data.margin - flag specifying if margin trading supported for pair
    */
   constructor (data = {}) {
@@ -37,8 +35,6 @@ class SymbolDetails extends Model {
    */
   static unserialize (data) {
     const obj = super.unserialize({ data, fields })
-    obj.pricePrecision = 5
-    obj.expiration = 'N/A'
     obj.margin = !isNil(obj.initialMargin) && !isNil(obj.minimumMargin)
 
     return obj

test/lib/models/symbol_details.js

@@ -14,25 +14,21 @@ describe('Symbol Details model', () => {
     model: SymbolDetails,
     validData: {
       pair: VALID_SYMBOLS,
-      pricePrecision: [5],
       initialMargin: new Array(...(new Array(5))).map(() => Math.random()),
       minimumMargin: new Array(...(new Array(5))).map(() => Math.random()),
       maximumOrderSize: new Array(...(new Array(5))).map(() => Math.random().toString()),
       minimumOrderSize: new Array(...(new Array(5))).map(() => Math.random().toString()),
-      expiration: ['N/A'],
-      margin: [true]
+      margin: [true, false]
     }
   })
 
   it('initializes correctly', () => {
     const details = new SymbolDetails(DATA)
     assert.strictEqual(details.pair, 'BTCEUR')
-    assert.strictEqual(details.pricePrecision, 5)
     assert.strictEqual(details.initialMargin, 0.2)
     assert.strictEqual(details.minimumMargin, 0.1)
     assert.strictEqual(details.maximumOrderSize, '2000.0')
     assert.strictEqual(details.minimumOrderSize, '0.0002')
-    assert.strictEqual(details.expiration, 'N/A')
     assert.strictEqual(details.margin, true)
   })
 
@@ -46,12 +42,10 @@ describe('Symbol Details model', () => {
   it('unserializes correctly', () => {
     const details = SymbolDetails.unserialize(DATA)
     assert.strictEqual(details.pair, 'BTCEUR')
-    assert.strictEqual(details.pricePrecision, 5)
     assert.strictEqual(details.initialMargin, 0.2)
     assert.strictEqual(details.minimumMargin, 0.1)
     assert.strictEqual(details.maximumOrderSize, '2000.0')
     assert.strictEqual(details.minimumOrderSize, '0.0002')
-    assert.strictEqual(details.expiration, 'N/A')
     assert.strictEqual(details.margin, true)
   })
 })