From d0253d716c12ad159d199da2d9973547a12ab9e0 Mon Sep 17 00:00:00 2001 From: Vladimir Voronkov Date: Mon, 20 Apr 2026 14:47:03 +0300 Subject: [PATCH 1/7] Remove isSignatureRequired param from validation --- workers/loc.api/data-validator/schemas/fwGetCandlesFileReq.js | 3 --- .../loc.api/data-validator/schemas/getBalanceHistoryFileReq.js | 3 --- .../data-validator/schemas/getFullSnapshotReportFileReq.js | 3 --- .../loc.api/data-validator/schemas/getFullTaxReportFileReq.js | 3 --- .../loc.api/data-validator/schemas/getPerformingLoanFileReq.js | 3 --- .../data-validator/schemas/getPositionsSnapshotFileReq.js | 3 --- .../data-validator/schemas/getTotalFeesReportFileReq.js | 3 --- .../loc.api/data-validator/schemas/getTradedVolumeFileReq.js | 3 --- .../data-validator/schemas/getTransactionTaxReportFileReq.js | 3 --- workers/loc.api/data-validator/schemas/getWinLossFileReq.js | 3 --- .../schemas/getWinLossVSAccountBalanceFileReq.js | 3 --- 11 files changed, 33 deletions(-) diff --git a/workers/loc.api/data-validator/schemas/fwGetCandlesFileReq.js b/workers/loc.api/data-validator/schemas/fwGetCandlesFileReq.js index 8af9ab22..a9d08e74 100644 --- a/workers/loc.api/data-validator/schemas/fwGetCandlesFileReq.js +++ b/workers/loc.api/data-validator/schemas/fwGetCandlesFileReq.js @@ -51,9 +51,6 @@ module.exports = { }, isPDFRequired: { $ref: 'defs#/definitions/isPDFRequired' - }, - isSignatureRequired: { - $ref: 'defs#/definitions/isSignatureRequired' } } } diff --git a/workers/loc.api/data-validator/schemas/getBalanceHistoryFileReq.js b/workers/loc.api/data-validator/schemas/getBalanceHistoryFileReq.js index 1f2f2fb0..e7178397 100644 --- a/workers/loc.api/data-validator/schemas/getBalanceHistoryFileReq.js +++ b/workers/loc.api/data-validator/schemas/getBalanceHistoryFileReq.js @@ -37,9 +37,6 @@ module.exports = { }, isPDFRequired: { $ref: 'defs#/definitions/isPDFRequired' - }, - isSignatureRequired: { - $ref: 'defs#/definitions/isSignatureRequired' } } } diff --git a/workers/loc.api/data-validator/schemas/getFullSnapshotReportFileReq.js b/workers/loc.api/data-validator/schemas/getFullSnapshotReportFileReq.js index 0af70a37..d16dc90f 100644 --- a/workers/loc.api/data-validator/schemas/getFullSnapshotReportFileReq.js +++ b/workers/loc.api/data-validator/schemas/getFullSnapshotReportFileReq.js @@ -34,9 +34,6 @@ module.exports = { }, isPDFRequired: { $ref: 'defs#/definitions/isPDFRequired' - }, - isSignatureRequired: { - $ref: 'defs#/definitions/isSignatureRequired' } } } diff --git a/workers/loc.api/data-validator/schemas/getFullTaxReportFileReq.js b/workers/loc.api/data-validator/schemas/getFullTaxReportFileReq.js index 97f2938f..96452a77 100644 --- a/workers/loc.api/data-validator/schemas/getFullTaxReportFileReq.js +++ b/workers/loc.api/data-validator/schemas/getFullTaxReportFileReq.js @@ -37,9 +37,6 @@ module.exports = { }, isPDFRequired: { $ref: 'defs#/definitions/isPDFRequired' - }, - isSignatureRequired: { - $ref: 'defs#/definitions/isSignatureRequired' } } } diff --git a/workers/loc.api/data-validator/schemas/getPerformingLoanFileReq.js b/workers/loc.api/data-validator/schemas/getPerformingLoanFileReq.js index 07a981a0..aee3f35a 100644 --- a/workers/loc.api/data-validator/schemas/getPerformingLoanFileReq.js +++ b/workers/loc.api/data-validator/schemas/getPerformingLoanFileReq.js @@ -37,9 +37,6 @@ module.exports = { }, isPDFRequired: { $ref: 'defs#/definitions/isPDFRequired' - }, - isSignatureRequired: { - $ref: 'defs#/definitions/isSignatureRequired' } } } diff --git a/workers/loc.api/data-validator/schemas/getPositionsSnapshotFileReq.js b/workers/loc.api/data-validator/schemas/getPositionsSnapshotFileReq.js index da85d4a9..c035f04b 100644 --- a/workers/loc.api/data-validator/schemas/getPositionsSnapshotFileReq.js +++ b/workers/loc.api/data-validator/schemas/getPositionsSnapshotFileReq.js @@ -28,9 +28,6 @@ module.exports = { }, isPDFRequired: { $ref: 'defs#/definitions/isPDFRequired' - }, - isSignatureRequired: { - $ref: 'defs#/definitions/isSignatureRequired' } } } diff --git a/workers/loc.api/data-validator/schemas/getTotalFeesReportFileReq.js b/workers/loc.api/data-validator/schemas/getTotalFeesReportFileReq.js index 374b2cea..ee8722b5 100644 --- a/workers/loc.api/data-validator/schemas/getTotalFeesReportFileReq.js +++ b/workers/loc.api/data-validator/schemas/getTotalFeesReportFileReq.js @@ -43,9 +43,6 @@ module.exports = { }, isPDFRequired: { $ref: 'defs#/definitions/isPDFRequired' - }, - isSignatureRequired: { - $ref: 'defs#/definitions/isSignatureRequired' } } } diff --git a/workers/loc.api/data-validator/schemas/getTradedVolumeFileReq.js b/workers/loc.api/data-validator/schemas/getTradedVolumeFileReq.js index 9726fddd..eefbda13 100644 --- a/workers/loc.api/data-validator/schemas/getTradedVolumeFileReq.js +++ b/workers/loc.api/data-validator/schemas/getTradedVolumeFileReq.js @@ -37,9 +37,6 @@ module.exports = { }, isPDFRequired: { $ref: 'defs#/definitions/isPDFRequired' - }, - isSignatureRequired: { - $ref: 'defs#/definitions/isSignatureRequired' } } } diff --git a/workers/loc.api/data-validator/schemas/getTransactionTaxReportFileReq.js b/workers/loc.api/data-validator/schemas/getTransactionTaxReportFileReq.js index 31d8db87..ccc218e6 100644 --- a/workers/loc.api/data-validator/schemas/getTransactionTaxReportFileReq.js +++ b/workers/loc.api/data-validator/schemas/getTransactionTaxReportFileReq.js @@ -37,9 +37,6 @@ module.exports = { }, isPDFRequired: { $ref: 'defs#/definitions/isPDFRequired' - }, - isSignatureRequired: { - $ref: 'defs#/definitions/isSignatureRequired' } } } diff --git a/workers/loc.api/data-validator/schemas/getWinLossFileReq.js b/workers/loc.api/data-validator/schemas/getWinLossFileReq.js index 84fb0a12..10c2b96f 100644 --- a/workers/loc.api/data-validator/schemas/getWinLossFileReq.js +++ b/workers/loc.api/data-validator/schemas/getWinLossFileReq.js @@ -37,9 +37,6 @@ module.exports = { }, isPDFRequired: { $ref: 'defs#/definitions/isPDFRequired' - }, - isSignatureRequired: { - $ref: 'defs#/definitions/isSignatureRequired' } } } diff --git a/workers/loc.api/data-validator/schemas/getWinLossVSAccountBalanceFileReq.js b/workers/loc.api/data-validator/schemas/getWinLossVSAccountBalanceFileReq.js index fd0262c8..d7f4ff56 100644 --- a/workers/loc.api/data-validator/schemas/getWinLossVSAccountBalanceFileReq.js +++ b/workers/loc.api/data-validator/schemas/getWinLossVSAccountBalanceFileReq.js @@ -40,9 +40,6 @@ module.exports = { }, isPDFRequired: { $ref: 'defs#/definitions/isPDFRequired' - }, - isSignatureRequired: { - $ref: 'defs#/definitions/isSignatureRequired' } } } From 3fc912195708b0fce1fbccc23fc6756c0b0da828 Mon Sep 17 00:00:00 2001 From: Vladimir Voronkov Date: Wed, 29 Apr 2026 09:42:49 +0300 Subject: [PATCH 2/7] Fix GH Actions workflow permissions --- .github/workflows/ci.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 443ae083..63e200b0 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -39,4 +39,8 @@ jobs: path: test-report.json web-page-report: needs: linux-test-runner + permissions: + contents: read + actions: read + checks: write uses: ./.github/workflows/test-report.yml From 598011b1cd55c57a5ee441eb9083ae0dcc3f2c2c Mon Sep 17 00:00:00 2001 From: Vladimir Voronkov Date: Wed, 29 Apr 2026 11:27:39 +0300 Subject: [PATCH 3/7] Bump version up to 5.1.0 --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index 7b6a1014..8d912059 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@bitfinex/bfx-reports-framework", - "version": "5.0.0", + "version": "5.1.0", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@bitfinex/bfx-reports-framework", - "version": "5.0.0", + "version": "5.1.0", "license": "Apache-2.0", "dependencies": { "@bitfinex/bfx-facs-db-better-sqlite": "git+https://github.com/bitfinexcom/bfx-facs-db-better-sqlite.git", diff --git a/package.json b/package.json index f39d6590..2fc3219f 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@bitfinex/bfx-reports-framework", - "version": "5.0.0", + "version": "5.1.0", "description": "Bitfinex reports framework", "main": "worker.js", "engines": { From e2aec50abb82cf9b2688c54a401eb4075159b361 Mon Sep 17 00:00:00 2001 From: Vladimir Voronkov Date: Wed, 29 Apr 2026 11:29:48 +0300 Subject: [PATCH 4/7] Update bfx-report-ui sub-module --- bfx-report-ui | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bfx-report-ui b/bfx-report-ui index 16f44e0a..a68255e3 160000 --- a/bfx-report-ui +++ b/bfx-report-ui @@ -1 +1 @@ -Subproject commit 16f44e0a39e9cbfd9575a39e98ab5dd8b7dee199 +Subproject commit a68255e3243738fedde64de5a75a00557639d8c1 From cbefea1ace3625a052543607e053883ff57193a2 Mon Sep 17 00:00:00 2001 From: Vladimir Voronkov Date: Wed, 29 Apr 2026 11:32:17 +0300 Subject: [PATCH 5/7] Update @bitfinex/bfx-facs-db-better-sqlite dep --- package-lock.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index 8d912059..353fab55 100644 --- a/package-lock.json +++ b/package-lock.json @@ -135,8 +135,8 @@ } }, "node_modules/@bitfinex/bfx-facs-db-better-sqlite": { - "version": "2.1.0", - "resolved": "git+ssh://git@github.com/bitfinexcom/bfx-facs-db-better-sqlite.git#197e840d581d340c986d4c0c83c53e65094b8367", + "version": "2.1.1", + "resolved": "git+ssh://git@github.com/bitfinexcom/bfx-facs-db-better-sqlite.git#c0c129a39ae52200575052091750a16d43e772cc", "license": "Apache-2.0", "dependencies": { "@bitfinex/bfx-facs-base": "git+https://github.com/bitfinexcom/bfx-facs-base.git", From 26f31ee9232e8fa7f8ac87e6bdf676b2e85bd17a Mon Sep 17 00:00:00 2001 From: Vladimir Voronkov Date: Wed, 29 Apr 2026 11:33:26 +0300 Subject: [PATCH 6/7] Update @bitfinex/bfx-report-express dep --- package-lock.json | 32 ++------------------------------ 1 file changed, 2 insertions(+), 30 deletions(-) diff --git a/package-lock.json b/package-lock.json index 353fab55..f8634645 100644 --- a/package-lock.json +++ b/package-lock.json @@ -270,12 +270,11 @@ } }, "node_modules/@bitfinex/bfx-report-express": { - "version": "3.0.0", - "resolved": "git+ssh://git@github.com/bitfinexcom/bfx-report-express.git#313b5c7450af639adb42e0b2632a1432d389988f", + "version": "3.1.0", + "resolved": "git+ssh://git@github.com/bitfinexcom/bfx-report-express.git#510163a94336f889364da7b248103df804ef3a05", "dev": true, "license": "Apache-2.0", "dependencies": { - "better-npm-run": "0.1.1", "colors": "1.4.0", "config": "4.4.1", "cors": "2.8.6", @@ -1418,21 +1417,6 @@ "integrity": "sha512-D/vrAD4dLVX23NalHwb8dSvsUsxeRPO8Y7ToKA015JQYq69MLDOMkC0uGZYA/MPpltLO8rt8eqFC2j8DxjTZ/w==", "dev": true }, - "node_modules/better-npm-run": { - "version": "0.1.1", - "resolved": "https://registry.npmjs.org/better-npm-run/-/better-npm-run-0.1.1.tgz", - "integrity": "sha512-SBBYsUsb6bYcUMF9QUWy39GX5kzD4CoRBP11gx/k5jYkUr4Tr+irAokIeQX5FgfCRz0Q27rt8U0J4D2TlRgQFA==", - "dev": true, - "dependencies": { - "commander": "^2.9.0", - "dotenv": "^2.0.0", - "object-assign": "^4.0.1" - }, - "bin": { - "better-npm-run": "index.js", - "bnr": "index.js" - } - }, "node_modules/better-sqlite3": { "version": "12.6.2", "resolved": "https://registry.npmjs.org/better-sqlite3/-/better-sqlite3-12.6.2.tgz", @@ -2248,12 +2232,6 @@ "node": ">= 0.8" } }, - "node_modules/commander": { - "version": "2.20.3", - "resolved": "https://registry.npmjs.org/commander/-/commander-2.20.3.tgz", - "integrity": "sha512-GpVkmM8vF2vQUkj2LvZmD35JxeJOLCwJ9cUkugyk2nuhbv3+mJvpLYYt+0+USMxE+oj+ey/lJEnhZw75x/OMcQ==", - "dev": true - }, "node_modules/complex.js": { "version": "2.4.2", "resolved": "https://registry.npmjs.org/complex.js/-/complex.js-2.4.2.tgz", @@ -2885,12 +2863,6 @@ "integrity": "sha512-LLBi6pEqS6Do3EKQ3J0NqHWV5hhb78Pi8vvESYwyOy2c31ZEZVdtitdzsQsKb7878PEERhzUk0ftqGhG6Mz+pQ==", "license": "MIT" }, - "node_modules/dotenv": { - "version": "2.0.0", - "resolved": "https://registry.npmjs.org/dotenv/-/dotenv-2.0.0.tgz", - "integrity": "sha512-Y+zZAmv7p2zOdpyZcSIA+aIxohsyfTcNaMeh3YJn9exq85bQhso65Wz9IhjYYNB4zyvXnfi7Ae+FuygARljVJw==", - "dev": true - }, "node_modules/dunder-proto": { "version": "1.0.1", "resolved": "https://registry.npmjs.org/dunder-proto/-/dunder-proto-1.0.1.tgz", From 735253b8facfdc400a467457bf69279a2deb0b9b Mon Sep 17 00:00:00 2001 From: Vladimir Voronkov Date: Wed, 29 Apr 2026 13:01:02 +0300 Subject: [PATCH 7/7] Update @bitfinex/bfx-report dep --- package-lock.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index f8634645..89c7b358 100644 --- a/package-lock.json +++ b/package-lock.json @@ -235,8 +235,8 @@ } }, "node_modules/@bitfinex/bfx-report": { - "version": "5.0.0", - "resolved": "git+ssh://git@github.com/bitfinexcom/bfx-report.git#bb4136cb86efe423ad23626bd507fcfc023b7320", + "version": "5.1.0", + "resolved": "git+ssh://git@github.com/bitfinexcom/bfx-report.git#762548c2441e95c81f0f86765399984440531cd3", "license": "Apache-2.0", "dependencies": { "@bitfinex/bfx-facs-deflate": "git+https://github.com/bitfinexcom/bfx-facs-deflate.git",