Skip to content

Commit 4ef0d70

Browse files
authored
Merge pull request #240 from bitfinity-network/alloy_update
Upgrade to alloy 0.15
2 parents d4278ff + 9697771 commit 4ef0d70

5 files changed

Lines changed: 19 additions & 22 deletions

File tree

Cargo.toml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ homepage = "https://github.com/bitfinity-network/bitfinity-evm-sdk"
2222
include = ["src/**/*", "LICENSE", "README.md"]
2323
license = "MIT"
2424
repository = "https://github.com/bitfinity-network/bitfinity-evm-sdk"
25-
version = "0.49.0"
25+
version = "0.50.0"
2626

2727
[workspace.dependencies]
2828
did = { path = "src/did" }
@@ -34,7 +34,7 @@ evm-canister-client = { path = "src/evm-canister-client" }
3434
evm-log-extractor = { path = "src/evm-log-extractor" }
3535
signature-verification-canister-client = { path = "src/signature-verification-canister-client" }
3636

37-
alloy = { version = "0.13", default-features = false, features = [
37+
alloy = { version = "0.15", default-features = false, features = [
3838
"consensus",
3939
"k256",
4040
"eips",
@@ -58,8 +58,8 @@ ic-exports = { git = "https://github.com/bitfinity-network/canister-sdk", packag
5858
ic-log = { git = "https://github.com/bitfinity-network/canister-sdk", package = "ic-log", tag = "v0.24.x" }
5959
ic-stable-structures = { git = "https://github.com/bitfinity-network/canister-sdk", package = "ic-stable-structures", tag = "v0.24.x" }
6060
itertools = "0.14"
61-
jsonrpsee = { version = "0.24", features = ["server", "macros"] }
62-
lightspeed_scheduler = "0.60"
61+
jsonrpsee = { version = "0.25", features = ["server", "macros"] }
62+
lightspeed_scheduler = "0.63"
6363
log = "0.4"
6464
num = "0.4"
6565
port_check = "0.2"

src/did/src/transaction.rs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ impl Signature {
228228
/// Recovers an [`Address`] from this signature and the given prehashed message.
229229
/// e.g.: signature.recover_from(&tx.signature_hash())
230230
pub fn recover_from(&self, signature_hash: &H256) -> Result<H160, EvmError> {
231-
let primitive_signature = alloy::primitives::PrimitiveSignature::from(self);
231+
let primitive_signature = alloy::primitives::Signature::from(self);
232232
let recovered_from = primitive_signature
233233
.recover_address_from_prehash(&signature_hash.0)
234234
.map_err(|err| EvmError::SignatureError(format!("{err:?}")))?;
@@ -249,20 +249,20 @@ impl Signature {
249249
}
250250
}
251251

252-
impl From<Signature> for alloy::primitives::PrimitiveSignature {
252+
impl From<Signature> for alloy::primitives::Signature {
253253
fn from(value: Signature) -> Self {
254-
alloy::primitives::PrimitiveSignature::new(value.r.0, value.s.0, value.y_parity.as_bool())
254+
alloy::primitives::Signature::new(value.r.0, value.s.0, value.y_parity.as_bool())
255255
}
256256
}
257257

258-
impl From<&Signature> for alloy::primitives::PrimitiveSignature {
258+
impl From<&Signature> for alloy::primitives::Signature {
259259
fn from(value: &Signature) -> Self {
260-
alloy::primitives::PrimitiveSignature::new(value.r.0, value.s.0, value.y_parity.as_bool())
260+
alloy::primitives::Signature::new(value.r.0, value.s.0, value.y_parity.as_bool())
261261
}
262262
}
263263

264-
impl From<alloy::primitives::PrimitiveSignature> for Signature {
265-
fn from(value: alloy::primitives::PrimitiveSignature) -> Self {
264+
impl From<alloy::primitives::Signature> for Signature {
265+
fn from(value: alloy::primitives::Signature) -> Self {
266266
Self {
267267
r: U256(value.r()),
268268
s: U256(value.s()),
@@ -514,7 +514,7 @@ impl TryFrom<Transaction> for alloy::rpc::types::Transaction {
514514
fn try_from(tx: Transaction) -> Result<Self, EvmError> {
515515
let signature = Signature::new_from_rsv(tx.r, tx.s, tx.v.as_u64())?;
516516

517-
let signature = alloy::primitives::PrimitiveSignature::from(signature);
517+
let signature = alloy::primitives::Signature::from(signature);
518518

519519
let tx_type = tx.transaction_type.unwrap_or_default().0.to::<u64>();
520520
match tx_type {
@@ -1604,7 +1604,7 @@ mod test {
16041604

16051605
#[test]
16061606
fn primitive_signature_roundtrip() {
1607-
let signature = alloy::primitives::PrimitiveSignature::new(
1607+
let signature = alloy::primitives::Signature::new(
16081608
alloy::primitives::U256::from(random::<u64>()),
16091609
alloy::primitives::U256::from(random::<u64>()),
16101610
random(),
@@ -1613,7 +1613,7 @@ mod test {
16131613
let roundtrip_signature = Signature::from(signature);
16141614
assert_eq!(
16151615
signature,
1616-
alloy::primitives::PrimitiveSignature::from(roundtrip_signature)
1616+
alloy::primitives::Signature::from(roundtrip_signature)
16171617
);
16181618
}
16191619

src/eth-signer/src/ic_sign.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
use std::fmt;
22

33
use alloy::consensus::SignableTransaction;
4-
use alloy::primitives::{Address, PrimitiveSignature, SignatureError, U256};
4+
use alloy::primitives::{Address, Signature as PrimitiveSignature, SignatureError, U256};
55
use alloy::signers::k256::ecdsa::{RecoveryId, Signature as EcsaSignature, VerifyingKey};
66
use alloy::signers::utils::public_key_to_address;
77
use candid::{CandidType, Principal};
@@ -281,7 +281,7 @@ mod tests {
281281
.await
282282
.unwrap();
283283

284-
let primitive_signature = alloy::primitives::PrimitiveSignature::from(signature);
284+
let primitive_signature = alloy::primitives::Signature::from(signature);
285285

286286
let recovered_from = primitive_signature
287287
.recover_address_from_prehash(&tx.signature_hash())

src/eth-signer/src/sign_strategy.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ use std::borrow::Cow;
22

33
use alloy::consensus::SignableTransaction;
44
use alloy::network::TxSigner as NetworkTxSigner;
5-
use alloy::primitives::PrimitiveSignature;
5+
use alloy::primitives::Signature as PrimitiveSignature;
66
use alloy::signers::Signer;
77
use alloy::signers::k256::ecdsa::{self, SigningKey};
88
use alloy::signers::utils::secret_key_to_address;
@@ -339,7 +339,7 @@ mod test {
339339
let digest = [42u8; 32];
340340
let signature = signer.sign_digest(digest).await.unwrap();
341341

342-
let recovered = alloy::primitives::PrimitiveSignature::from(signature)
342+
let recovered = alloy::primitives::Signature::from(signature)
343343
.recover_address_from_prehash(&alloy::primitives::B256::from_slice(&digest))
344344
.unwrap();
345345

src/ethereum-json-rpc-client/tests/reqwest/mod.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -107,10 +107,7 @@ async fn should_perform_eth_call() {
107107
.unwrap();
108108

109109
let result_address = func
110-
.abi_decode_output(
111-
&alloy::hex::decode(result.trim_start_matches("0x")).unwrap(),
112-
false,
113-
)
110+
.abi_decode_output(&alloy::hex::decode(result.trim_start_matches("0x")).unwrap())
114111
.unwrap()
115112
.first()
116113
.cloned()

0 commit comments

Comments
 (0)