Skip to content

Remove async trait#242

Merged
ufoscout merged 5 commits into
mainfrom
remove_async_trait
May 6, 2025
Merged

Remove async trait#242
ufoscout merged 5 commits into
mainfrom
remove_async_trait

Conversation

@ufoscout

@ufoscout ufoscout commented May 5, 2025

Copy link
Copy Markdown
Contributor

Issue ticket

Issue ticket link: <>

Checklist before requesting a review

Code conventions

  • I have performed a self-review of my code
  • Every new function is documented
  • Object names are auto explicative

Security

  • The PR does not break APIs backward compatibility
  • The PR does not break the stable storage backward compatibility

Testing

  • Every function is properly unit tested
  • I have added integration tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • IC endpoints are always tested through the canister_call! macro

Comment thread Cargo.toml Outdated
@ufoscout ufoscout requested review from Maximkaaa, itsyaasir and veeso May 5, 2025 12:37
@ufoscout ufoscout merged commit f173774 into main May 6, 2025
1 check passed
@ufoscout ufoscout deleted the remove_async_trait branch May 6, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants