Skip to content

EPROD-1197 added block confirmation strategy in EVM canister#243

Merged
veeso merged 1 commit into
mainfrom
EPROD-1197-after-a-canister-upgrade-set-blockconfirmation-strategy-if-unset
May 16, 2025
Merged

EPROD-1197 added block confirmation strategy in EVM canister#243
veeso merged 1 commit into
mainfrom
EPROD-1197-after-a-canister-upgrade-set-blockconfirmation-strategy-if-unset

Conversation

@veeso

@veeso veeso commented May 15, 2025

Copy link
Copy Markdown
Contributor

@veeso veeso requested review from Maximkaaa, itsyaasir and ufoscout May 15, 2025 10:13

@ufoscout ufoscout left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to be changed as discussed:

impl<M: Memory> BlockConfirmer<M> {
    /// Create a new block confirmer with the given strategy.
    pub fn new(memory_manager: &dyn MemoryManager<M, u8>) -> Self {
        Self {
            strategy: StableCell::new(
                memory_manager.get(BLOCKCHAIN_BLOCK_CONFIRMER_STRATEGY_MEMORY_ID),
                BlockConfirmationStrategy::None,
            )
            .expect("failed to init block confirmer strategy cell"),
            pow_cache: Default::default(),
        }
    }

In addition, just scripts need to be fixed

@veeso veeso merged commit ec4128f into main May 16, 2025
1 check passed
@veeso veeso deleted the EPROD-1197-after-a-canister-upgrade-set-blockconfirmation-strategy-if-unset branch May 16, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants