Run checkSyncSettings on lifecycle resume#659
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR changes when checkSyncSettings is called to match the original lifecycle behavior before PR #640. The change ensures that sync settings are checked whenever the screen resumes, not just when it's initially launched.
- Moved
checkSyncSettingscall fromLaunchedEffecttoLifecycleResumeEffect - Added import for
LifecycleResumeEffect - Maintained the existing permission request logic in
LaunchedEffect
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
sunkup
approved these changes
Aug 19, 2025
Member
sunkup
left a comment
There was a problem hiding this comment.
That works. I wonder whether we can get rid of the effects at some point ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Before #640 we were calling
checkSyncSettingsin the activity'sonResumefunction.However, after the PR, it was replaced by a simple
LaunchedEffect. It should beLifecycleResumeEffectto match the original behavior.Short description
Moved
checkSyncSettingsto aLifecycleResumeEffect.Checklist