EditSubscriptionScreen wrongly goes into edited state

[ArnyminerZ]

Purpose

The edit subscription screen is misdetecting changes as dirty.

Short description

• Fix typo.

That was a tough one to spot.

Checklist

• The PR has a proper title, description and label.
• I have self-reviewed the PR.
• I have added documentation to complex functions and functions that can be used by other modules.
• I have added reasonable tests or consciously decided to not add tests.

[sunkup]

I would love to say that fixes it. But it still happens :/ And I totally get that this is hard to debug. I feel like the state of the whole code base is not good, because we mix so many approaches at the moment.

[ArnyminerZ]

Okay, now it should be good. The thing was that all initialSubscription, initialCredential and initialRequiresAuthValue were regular variables, and as such, the UI was not updating when they change. Since they were initialized after all the subscriptionSettingsUseCase.set* calls, if the UI was updated quickly, their value was not correctly retrieved upon refreshing inputValid. I've moved them, and now it's good. Please test and see

Edit: not working... I'll give it another try

[sunkup]

Very nice! It's always pleasing to see when code can be deleted. We should also update the kdoc though.

At some point we should use flows instead of LaunchedEffect or the view model init method, but for now let's get this working as is. 👍

[Copilot]

Pull Request Overview

This PR fixes a bug where the EditSubscriptionScreen was incorrectly detecting changes as dirty due to a typo in property comparison. The fix involves replacing reactive flow collection with direct data fetching and consolidating the subscription state initialization logic.

• Replace flow-based subscription loading with direct database query to avoid state synchronization issues
• Consolidate subscription and credential initialization into a single update() method
• Fix property comparison for dirty state detection by using computed property instead of stored variable

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
EditSubscriptionScreen.kt	Remove flow collection and use direct property access for subscription data
SubscriptionSettingsUseCase.kt	Add update() method to initialize UI state from subscription and credential data
EditSubscriptionModel.kt	Replace flow-based loading with direct query and fix dirty state detection logic
SubscriptionsDao.kt	Add non-flow method to get subscription with credentials by ID

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[sunkup]

Ready to merge when you want to 👍