Skip to content

Migrate InfoActivity to Nav3#666

Merged
ArnyminerZ merged 7 commits into
devfrom
nav3-migration/info-activity
Sep 1, 2025
Merged

Migrate InfoActivity to Nav3#666
ArnyminerZ merged 7 commits into
devfrom
nav3-migration/info-activity

Conversation

@ArnyminerZ

@ArnyminerZ ArnyminerZ commented Aug 25, 2025

Copy link
Copy Markdown
Member

Purpose

Migrate the last missing activity (InfoActivity) to Nav3.

Since all the composables were in InfoActivity, this PR requires quite a lot of code to be moved around.

Short description

  • Migrate InfoActivity to Nav3.

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@ArnyminerZ ArnyminerZ self-assigned this Aug 25, 2025
@ArnyminerZ ArnyminerZ added the refactoring Quality improvement of existing functions label Aug 25, 2025
@ArnyminerZ ArnyminerZ mentioned this pull request Aug 21, 2025
4 tasks
@ArnyminerZ ArnyminerZ requested a review from Copilot August 27, 2025 13:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the InfoActivity to Nav3 navigation system by converting it from an Activity-based implementation to a Composable screen. The migration consolidates all composables from the InfoActivity into a new InfoScreen, removes the activity from the manifest, and updates navigation to use the new screen.

  • Move InfoActivity composables to new InfoScreen
  • Add Info destination to Nav3 navigation
  • Update SubscriptionsScreen to use navigation callback instead of starting activity

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
SubscriptionsScreen.kt Removes InfoActivity import and updates to use navigation callback parameter
InfoScreen.kt New screen containing migrated composables from InfoActivity
MainApp.kt Adds InfoScreen entry to navigation with proper routing
Destination.kt Adds Info destination object for navigation
InfoActivity.kt Completely removed - migrated to InfoScreen
AndroidManifest.xml Removes InfoActivity declaration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread app/src/main/java/at/bitfire/icsdroid/ui/screen/InfoScreen.kt Outdated
Comment thread app/src/main/java/at/bitfire/icsdroid/ui/screen/InfoScreen.kt
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ marked this pull request as ready for review August 27, 2025 13:53
@ArnyminerZ ArnyminerZ requested a review from sunkup August 27, 2025 13:54

@sunkup sunkup left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good ~ One comment. Maybe you see other renaming improvements?

Comment thread app/src/main/java/at/bitfire/icsdroid/ui/nav/MainApp.kt Outdated
@sunkup sunkup added this to the 2.3.2 milestone Sep 1, 2025
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ requested a review from sunkup September 1, 2025 08:35

@sunkup sunkup left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge 👍

@ArnyminerZ ArnyminerZ merged commit fa58f54 into dev Sep 1, 2025
7 checks passed
@ArnyminerZ ArnyminerZ deleted the nav3-migration/info-activity branch September 1, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Quality improvement of existing functions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants