Migrate InfoActivity to Nav3#666
Merged
Merged
Conversation
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the InfoActivity to Nav3 navigation system by converting it from an Activity-based implementation to a Composable screen. The migration consolidates all composables from the InfoActivity into a new InfoScreen, removes the activity from the manifest, and updates navigation to use the new screen.
- Move InfoActivity composables to new InfoScreen
- Add Info destination to Nav3 navigation
- Update SubscriptionsScreen to use navigation callback instead of starting activity
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| SubscriptionsScreen.kt | Removes InfoActivity import and updates to use navigation callback parameter |
| InfoScreen.kt | New screen containing migrated composables from InfoActivity |
| MainApp.kt | Adds InfoScreen entry to navigation with proper routing |
| Destination.kt | Adds Info destination object for navigation |
| InfoActivity.kt | Completely removed - migrated to InfoScreen |
| AndroidManifest.xml | Removes InfoActivity declaration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
sunkup
requested changes
Aug 28, 2025
sunkup
left a comment
Member
There was a problem hiding this comment.
Good ~ One comment. Maybe you see other renaming improvements?
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Migrate the last missing activity (
InfoActivity) to Nav3.Since all the composables were in
InfoActivity, this PR requires quite a lot of code to be moved around.Short description
InfoActivityto Nav3.Checklist