Fix URL sharing#668
Merged
Merged
Conversation
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes URL sharing functionality by refactoring the intent parsing logic in the MainApp component. The implementation moves from lazy loading of URL data to eager parsing during navigation setup.
- Replaces LaunchedEffect-based URL extraction with direct intent parsing in the navigation destination calculation
- Adds URL parameter to the AddSubscription destination to pass parsed URL data
- Consolidates intent handling by passing the entire Intent object instead of just extras
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| MainActivity.kt | Updates MainApp call to pass entire intent and adds debug println |
| MainApp.kt | Refactors calculateInitialDestination to parse URLs from intent and removes LaunchedEffect |
| Destination.kt | Adds url parameter to AddSubscription destination |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Right now, sharing URLs is broken on ICSx⁵ (lazy implementation). Also it looks like it's not the best thing in the world in the current ICSx⁵ release (#675).
Short description
Cleanup of the intent parsing logic.
Checklist