Fix timeouts not being applied#685
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes timeout configuration by moving from OkHttp-specific timeout settings to Ktor's built-in timeout plugin, ensuring timeouts are properly applied across all HTTP client engines.
- Replaced OkHttp-specific timeout configuration with Ktor's HttpTimeout plugin
- Removed direct timeout settings from OkHttp engine configuration
- Added proper timeout values for connect (20s), request (60s), and socket (60s) operations
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ArnyminerZ
approved these changes
Sep 4, 2025
ArnyminerZ
left a comment
Member
There was a problem hiding this comment.
Looks good. I'd use this opportunity to also get rid of the followRedirects option in the engine, and close #686
sunkup
marked this pull request as ready for review
September 4, 2025 08:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Timeouts were not being applied correctly / at all.
Short description
https://ktor.io/docs/client-timeout.html
Checklist