Globally disable follow redirects#688
Merged
Merged
Conversation
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
sunkup
reviewed
Sep 4, 2025
sunkup
left a comment
Member
There was a problem hiding this comment.
Where is the sense in leaving followRedirects = false ?
Member
Author
Ooops absolutely my fault |
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR relocates the redirect disabling configuration from engine-specific settings to a global HTTP client configuration to ensure consistent behavior across all engines.
- Moves redirect disabling from conditional engine-specific blocks to global client configuration
- Adds explanatory comment about redirect handling being managed by CalendarFetcher
- Simplifies the configuration logic by removing conditional redirect settings
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
sunkup
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
We are trying to disable redirection following in the engine config. We don't even want to disable redirection, so remove that line.We do have to disable redirection, it's handled by
CalendarFetcher. Following the docs, this is the way to disable it so it can be handled by it.Short description
Remove the redirection disable in engine config.Checklist