Fix accepting a certificate crashing ICSx5#699
Merged
sunkup merged 5 commits intoSep 11, 2025
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a crash in ICSx5 that occurs when accepting a certificate by updating the cert4android library and implementing proper foreground state tracking.
- Updates cert4android library to version 41009d4 which likely contains the fix for the certificate acceptance crash
- Implements a ForegroundTracker singleton to track when the app is in the foreground/background
- Integrates the foreground tracking with cert4android's CustomCertManager to enable proper certificate dialog handling
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gradle/libs.versions.toml | Updates cert4android library version from f0964cb to 41009d4 |
| app/src/main/java/at/bitfire/icsdroid/ui/ForegroundTracker.kt | Adds new singleton class to track app foreground/background state using StateFlow |
| app/src/main/java/at/bitfire/icsdroid/ui/theme/Theme.kt | Integrates foreground tracking into the app theme using LifecycleResumeEffect |
| app/src/main/java/at/bitfire/icsdroid/AppHttpClient.kt | Updates CustomCertManager to use the ForegroundTracker instead of a hardcoded false value |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
sunkup
marked this pull request as ready for review
September 10, 2025 11:44
ArnyminerZ
approved these changes
Sep 11, 2025
Member
|
Feel free to merge |
…bscription-screen
sunkup
deleted the
697-accepting-certificate-starts-empty-add-subscription-screen
branch
September 11, 2025 11:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Accepting a certificate crashes ICSx5.
Short description
Checklist