Only update uiState once in checkSyncSettings#703
Merged
Conversation
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the checkSyncSettings function by consolidating multiple sequential uiState.copy() calls into a single update operation, reducing redundant state mutations and improving performance.
- Combines four separate
uiStateassignments into one batch update - Minor code formatting improvement for method parameter line breaking
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
sunkup
self-requested a review
September 11, 2025 12:20
sunkup
approved these changes
Sep 11, 2025
sunkup
left a comment
sunkup
left a comment
Member
There was a problem hiding this comment.
Weird, but seems like that does the trick 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
I think we were updating
uiStatetoo many times in so little time.Short description
Joined the multiple
uiStateupdates and copying to a single call incheckSyncSettings.Closes #658
Checklist