Fix screen orientation change clearing UI state#725
Merged
ArnyminerZ merged 1 commit intoSep 27, 2025
Conversation
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes an issue where screen orientation changes would clear UI state by preventing re-initialization of subscription settings values when the screen is recomposed.
- Added
isInitialized()check to prevent redundant initialization calls - Removed
@Singletonannotation to avoid shared state between screen instances - Added early return in
LaunchedEffectwhen UI state is already initialized
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| AddSubscriptionScreen.kt | Added initialization check to prevent clearing UI state on recomposition |
| SubscriptionSettingsUseCase.kt | Removed singleton scope and added isInitialized method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
sunkup
approved these changes
Sep 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
See #719
Short description
SubscriptionSettingsUseCase.UiState.isInitialized. Will just check whether the "initialization values" have been set (bysetInitialValuesfor example).LaunchedEffectblock ofAddSubscriptionScreen, to make suresetInitialValuesis not called again when screen is recomposed (for example, when rotating the screen).@Singletonannotation fromSubscriptionSettingsUseCase, because otherwise it was being shared among used instances, and state was moving around between screens.Checklist