Enable cookies#759
Merged
Merged
Conversation
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Closed
ArnyminerZ
added
the
pr-feature
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables basic HTTP cookie support to address issue #758, which involves cookie handling during HTTP redirects. The implementation uses Ktor's HttpCookies plugin with default in-memory storage, ensuring cookies persist across redirect chains but are cleared when the application restarts.
- Adds the
HttpCookiesplugin to the HTTP client configuration with default settings - Cookies are stored in memory only and cleared on app restart
- Enables cookie persistence across redirects handled by
CalendarFetcher
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR enables basic cookies support, to support use-cases like #758
Short description
This should fix the issue of #758, because it would keep the cookies after redirecting, but will have them clear after each restart.
Checklist