Filter the Accept-Charset header#792
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a custom Ktor client plugin to remove the Accept-Charset header from outgoing HTTP requests. This addresses compatibility issues with certain servers and aligns with RFC 9110 §12.5.2, which discourages the use of this header.
Changes:
- Added a custom client plugin using Ktor's
createClientPluginAPI that intercepts outgoing requests and removes theAccept-Charsetheader - Added necessary imports for the plugin API (
Send,createClientPlugin,HttpHeaders)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sunkup
requested changes
Jan 21, 2026
Member
sunkup
left a comment
sunkup
left a comment
There was a problem hiding this comment.
Nice. Looks really good. One thing only: Right now TestAppHttpClient is in net package, but AppHttpClient is not in a net package. I think we should always put the test file for the corresponding source file in same package structure. So the structure matches.
sunkup
approved these changes
Jan 28, 2026
Member
sunkup
left a comment
sunkup
left a comment
There was a problem hiding this comment.
Looks good now. Please merge 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
See #791
Short description
Accept-Charsetheader before sending.Checklist