Implement PercentCompleteHandler with unit test

Author: sunkup

lib/src/main/kotlin/at/bitfire/synctools/mapping/tasks/DmfsTaskProcessor.kt

@@ -15,6 +15,7 @@ import at.bitfire.synctools.mapping.tasks.handler.ClassificationHandler
 import at.bitfire.synctools.mapping.tasks.handler.CompletedHandler
 import at.bitfire.synctools.mapping.tasks.handler.DmfsTaskFieldHandler
 import at.bitfire.synctools.mapping.tasks.handler.DmfsTaskPropertyHandler
+import at.bitfire.synctools.mapping.tasks.handler.PercentCompleteHandler
 import at.bitfire.synctools.mapping.tasks.handler.PriorityHandler
 import at.bitfire.synctools.mapping.tasks.handler.SequenceHandler
 import at.bitfire.synctools.mapping.tasks.handler.StatusHandler
@@ -61,6 +62,7 @@ class DmfsTaskProcessor(
         ClassificationHandler(),
         StatusHandler(),
         CompletedHandler(),
+        PercentCompleteHandler(),
     )
 
     private val propertyHandlers: Map<String, DmfsTaskPropertyHandler> = mapOf(
@@ -100,8 +102,6 @@ class DmfsTaskProcessor(
 
         // Note: big method – maybe split? Depends on how we want to proceed with refactoring.
 
-        values.getAsInteger(Tasks.PERCENT_COMPLETE)?.let { to.percentComplete = it }
-
         val allDay = (values.getAsInteger(Tasks.IS_ALLDAY) ?: 0) != 0
 
         val tzID = values.getAsString(Tasks.TZ)

lib/src/main/kotlin/at/bitfire/synctools/mapping/tasks/handler/PercentCompleteHandler.kt

@@ -0,0 +1,21 @@
+/*
+ * This file is part of bitfireAT/synctools which is released under GPLv3.
+ * Copyright © All Contributors. See the LICENSE and AUTHOR files in the root directory for details.
+ * SPDX-License-Identifier: GPL-3.0-or-later
+ */
+
+package at.bitfire.synctools.mapping.tasks.handler
+
+import android.content.ContentValues
+import at.bitfire.ical4android.Task
+import org.dmfs.tasks.contract.TaskContract.Tasks
+
+class PercentCompleteHandler : DmfsTaskFieldHandler {
+
+    override fun process(from: ContentValues, to: Task) {
+        from.getAsInteger(Tasks.PERCENT_COMPLETE)?.let { percent ->
+            to.percentComplete = percent
+        }
+    }
+
+}

lib/src/test/kotlin/at/bitfire/synctools/mapping/tasks/handler/PercentCompleteHandlerTest.kt

@@ -0,0 +1,45 @@
+/*
+ * This file is part of bitfireAT/synctools which is released under GPLv3.
+ * Copyright © All Contributors. See the LICENSE and AUTHOR files in the root directory for details.
+ * SPDX-License-Identifier: GPL-3.0-or-later
+ */
+
+package at.bitfire.synctools.mapping.tasks.handler
+
+import android.content.ContentValues
+import androidx.core.content.contentValuesOf
+import at.bitfire.ical4android.Task
+import org.dmfs.tasks.contract.TaskContract.Tasks
+import org.junit.Assert.assertEquals
+import org.junit.Assert.assertNull
+import org.junit.Test
+import org.junit.runner.RunWith
+import org.robolectric.RobolectricTestRunner
+
+@RunWith(RobolectricTestRunner::class)
+class PercentCompleteHandlerTest {
+
+    private val handler = PercentCompleteHandler()
+
+    @Test
+    fun `No PERCENT_COMPLETE leaves percentComplete null`() {
+        val task = Task()
+        handler.process(ContentValues(), task)
+        assertNull(task.percentComplete)
+    }
+
+    @Test
+    fun `PERCENT_COMPLETE 0 is mapped correctly`() {
+        val task = Task()
+        handler.process(contentValuesOf(Tasks.PERCENT_COMPLETE to 0), task)
+        assertEquals(0, task.percentComplete)
+    }
+
+    @Test
+    fun `PERCENT_COMPLETE 100 is mapped correctly`() {
+        val task = Task()
+        handler.process(contentValuesOf(Tasks.PERCENT_COMPLETE to 100), task)
+        assertEquals(100, task.percentComplete)
+    }
+
+}