[jtx rewrite] Add handler for categories (#416)

* Add CategoriesHandler and tests

* Remove test

Author: ArnyminerZ

lib/src/main/kotlin/at/bitfire/synctools/mapping/jtx/JtxObjectHandler.kt

@@ -8,6 +8,7 @@ package at.bitfire.synctools.mapping.jtx
 
 import android.content.Entity
 import at.bitfire.synctools.icalendar.AssociatedComponents
+import at.bitfire.synctools.mapping.jtx.handler.CategoriesHandler
 import at.bitfire.synctools.mapping.jtx.handler.DescriptionHandler
 import at.bitfire.synctools.mapping.jtx.handler.JtxFieldHandler
 import at.bitfire.synctools.storage.jtx.JtxObjectAndExceptions
@@ -29,7 +30,8 @@ class JtxObjectHandler(
     private val prodId: ProdId
 ) {
     private val fieldHandlers: Array<JtxFieldHandler> = arrayOf(
-        DescriptionHandler()
+        CategoriesHandler(),
+        DescriptionHandler(),
     )
 
     /**

lib/src/main/kotlin/at/bitfire/synctools/mapping/jtx/handler/CategoriesHandler.kt

@@ -0,0 +1,26 @@
+/*
+ * This file is part of bitfireAT/synctools which is released under GPLv3.
+ * Copyright © All Contributors. See the LICENSE and AUTHOR files in the root directory for details.
+ * SPDX-License-Identifier: GPL-3.0-or-later
+ */
+
+package at.bitfire.synctools.mapping.jtx.handler
+
+import android.content.Entity
+import at.bitfire.synctools.icalendar.plusAssign
+import at.techbee.jtx.JtxContract
+import net.fortuna.ical4j.model.TextList
+import net.fortuna.ical4j.model.component.CalendarComponent
+import net.fortuna.ical4j.model.property.Categories
+
+class CategoriesHandler : JtxFieldHandler {
+    override fun process(from: Entity, main: Entity, to: CalendarComponent) {
+        val categoryTexts = from.subValues
+            .filter { it.uri == JtxContract.JtxCategory.CONTENT_URI }
+            .mapNotNull { it.values.getAsString(JtxContract.JtxCategory.TEXT) }
+
+        if (categoryTexts.isNotEmpty()) {
+            to += Categories(TextList(categoryTexts))
+        }
+    }
+}

lib/src/test/kotlin/at/bitfire/synctools/mapping/jtx/handler/CategoriesHandlerTest.kt

@@ -0,0 +1,94 @@
+/*
+ * This file is part of bitfireAT/synctools which is released under GPLv3.
+ * Copyright © All Contributors. See the LICENSE and AUTHOR files in the root directory for details.
+ * SPDX-License-Identifier: GPL-3.0-or-later
+ */
+
+package at.bitfire.synctools.mapping.jtx.handler
+
+import android.content.ContentValues
+import android.content.Entity
+import androidx.core.content.contentValuesOf
+import at.techbee.jtx.JtxContract
+import net.fortuna.ical4j.model.Property
+import net.fortuna.ical4j.model.component.VToDo
+import net.fortuna.ical4j.model.property.Categories
+import org.junit.Assert.assertEquals
+import org.junit.Assert.assertNull
+import org.junit.Test
+import org.junit.runner.RunWith
+import org.robolectric.RobolectricTestRunner
+import kotlin.jvm.optionals.getOrNull
+
+@RunWith(RobolectricTestRunner::class)
+class CategoriesHandlerTest {
+
+    private val handler = CategoriesHandler()
+
+    @Test
+    fun `No category sub-values produces no CATEGORIES property`() {
+        val from = Entity(ContentValues())
+        val output = VToDo()
+
+        handler.process(from = from, main = from, to = output)
+
+        assertNull(output.getProperty<Categories>(Property.CATEGORIES).getOrNull())
+    }
+
+    @Test
+    fun `Single category is mapped`() {
+        val from = Entity(ContentValues()).apply {
+            addSubValue(JtxContract.JtxCategory.CONTENT_URI, contentValuesOf(JtxContract.JtxCategory.TEXT to "work"))
+        }
+        val output = VToDo()
+
+        handler.process(from = from, main = from, to = output)
+
+        val categories = output.getProperty<Categories>(Property.CATEGORIES).getOrNull()
+        assertEquals(1, categories?.categories?.texts?.size)
+        assertEquals("work", categories?.categories?.texts?.first())
+    }
+
+    @Test
+    fun `Multiple categories are combined into one CATEGORIES property`() {
+        val from = Entity(ContentValues()).apply {
+            addSubValue(JtxContract.JtxCategory.CONTENT_URI, contentValuesOf(JtxContract.JtxCategory.TEXT to "work"))
+            addSubValue(JtxContract.JtxCategory.CONTENT_URI, contentValuesOf(JtxContract.JtxCategory.TEXT to "personal"))
+            addSubValue(JtxContract.JtxCategory.CONTENT_URI, contentValuesOf(JtxContract.JtxCategory.TEXT to "urgent"))
+        }
+        val output = VToDo()
+
+        handler.process(from = from, main = from, to = output)
+
+        val categories = output.getProperty<Categories>(Property.CATEGORIES).getOrNull()
+        assertEquals(3, categories?.categories?.texts?.size)
+        assertEquals(setOf("work", "personal", "urgent"), categories?.categories?.texts?.toSet())
+    }
+
+    @Test
+    fun `Category sub-value with null TEXT is skipped`() {
+        val from = Entity(ContentValues()).apply {
+            addSubValue(JtxContract.JtxCategory.CONTENT_URI, contentValuesOf(JtxContract.JtxCategory.TEXT to "work"))
+            addSubValue(JtxContract.JtxCategory.CONTENT_URI, ContentValues()) // no TEXT
+        }
+        val output = VToDo()
+
+        handler.process(from = from, main = from, to = output)
+
+        val categories = output.getProperty<Categories>(Property.CATEGORIES).getOrNull()
+        assertEquals(1, categories?.categories?.texts?.size)
+        assertEquals("work", categories?.categories?.texts?.first())
+    }
+
+    @Test
+    fun `Sub-values with other URIs are ignored`() {
+        val from = Entity(ContentValues()).apply {
+            addSubValue(JtxContract.JtxAlarm.CONTENT_URI, contentValuesOf(JtxContract.JtxCategory.TEXT to "should-be-ignored"))
+        }
+        val output = VToDo()
+
+        handler.process(from = from, main = from, to = output)
+
+        assertNull(output.getProperty<Categories>(Property.CATEGORIES).getOrNull())
+    }
+}