This repository was archived by the owner on May 26, 2026. It is now read-only.
Events: add VALUE=DATE to EXDATE for cancelled all-day exceptions#441
Merged
rfc2822 merged 2 commits intoMay 26, 2026
Merged
Conversation
rfc2822
added
pr-bugfix
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures that cancelled all-day recurring exceptions are exported as EXDATE entries with the correct iCalendar value type (VALUE=DATE), matching RFC 5545 expectations and improving interoperability with clients that require explicit VALUE=DATE for date-only exclusions.
Changes:
- Update
AndroidEventHandler.asExDate()to emitEXDATE;VALUE=DATE:<yyyymmdd>for cancelled all-day exceptions. - Strengthen recurrence-related tests to assert presence of
VALUE=DATEon all-dayEXDATE. - Add a dedicated mapping test case for cancelled all-day exceptions to prevent regression.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/src/main/kotlin/at/bitfire/synctools/mapping/calendar/AndroidEventHandler.kt | Adds VALUE=DATE parameter when generating EXDATE for cancelled all-day exceptions. |
| lib/src/test/kotlin/at/bitfire/synctools/mapping/calendar/AndroidEventHandlerTest.kt | Adds test coverage asserting EXDATE uses VALUE=DATE for cancelled all-day exceptions. |
| lib/src/test/kotlin/at/bitfire/synctools/mapping/calendar/handler/RecurrenceFieldHandlerTest.kt | Updates all-day recurrence test to assert EXDATE includes VALUE=DATE. |
sunkup
force-pushed
the
406-exdate-for-all-day-events-serialized-without-valuedate-http-415
branch
from
55b0c1b to
30de943
Compare
rfc2822
deleted the
406-exdate-for-all-day-events-serialized-without-valuedate-http-415
branch
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.