Reclassify and extend VMB tests for 2026 proposals

Author: bitjson

.changeset/healthy-planets-repeat.md

@@ -0,0 +1,5 @@
+---
+'@bitauth/libauth': patch
+---
+
+Rename `nonP2SH` to `P2S`

.changeset/kind-drinks-lie.md

@@ -0,0 +1,5 @@
+---
+'@bitauth/libauth': minor
+---
+
+Reclassify existing VMB tests for 2026 proposals, add additional tests

.changeset/plenty-frogs-vanish.md

@@ -0,0 +1,5 @@
+---
+'@bitauth/libauth': minor
+---
+
+Add `elideWordsAndHexAtLength`

.changeset/rare-carrots-fry.md

@@ -0,0 +1,5 @@
+---
+'@bitauth/libauth': minor
+---
+
+`yarn gen:vmb-tests` watch mode: rebuild only the modified file

.gitignore

@@ -17,6 +17,7 @@ src/lib/vmb-tests/export
 src/lib/vmb-tests/generated/.vmb-*
 src/lib/vmb-tests/generated/**/*bench.csv
 src/lib/vmb-tests/generated/bch_chip_*
+.DS_Store
 
 src/lib/bin/**/*.html
 src/lib/bin/**/*.js

package.json

@@ -44,8 +44,8 @@
     "bchn:cmake": "cd wasm/bitcoin-cash-node/build && cmake -GNinja .. -DBUILD_BITCOIN_WALLET=OFF -DBUILD_BITCOIN_QT=OFF -DENABLE_NATPMP=OFF -DENABLE_MAN=OFF -DCMAKE_BUILD_TYPE=Release",
     "bchn:build": "cd wasm/bitcoin-cash-node/build && ninja",
     "bchn:setup": "cd wasm/bitcoin-cash-node && mkdir build && yarn bchn:cmake && yarn bchn:build",
-    "bchn:remove-old-vmb-tests": "rm -r wasm/bitcoin-cash-node/src/test/data/vmb_tests/bch_{2023,2025}_{invalid,nonstandard,standard} && echo 'Removed old VMB tests from: wasm/bitcoin-cash-node/src/test/data/vmb_tests'",
-    "bchn:add-new-vmb-tests": "cp -r src/lib/vmb-tests/generated/* wasm/bitcoin-cash-node/src/test/data/vmb_tests && echo 'Added new VMB tests.'",
+    "bchn:remove-old-vmb-tests": "rm -r wasm/bitcoin-cash-node/src/test/data/vmb_tests/bch_{2023,2025,2026}_{invalid,nonstandard,standard} && echo 'Removed old VMB tests from: wasm/bitcoin-cash-node/src/test/data/vmb_tests'",
+    "bchn:add-new-vmb-tests": "cp -r src/lib/vmb-tests/generated/bch_{2023,2025,2026}_{invalid,nonstandard,standard} wasm/bitcoin-cash-node/src/test/data/vmb_tests && echo 'Added new VMB tests.'",
     "bchn:replace-vmb-tests": "yarn bchn:remove-old-vmb-tests && yarn bchn:add-new-vmb-tests",
     "bchn:run-tests": "cd wasm/bitcoin-cash-node/build && echo 'Building BCHN tests...' && ninja test_bitcoin && echo 'Running VMB tests in BCHN...' && src/test/test_bitcoin -t libauth_tests",
     "bchn:check-vmb-tests": "yarn bchn:cmake && yarn bchn:build && yarn bchn:run-tests",

src/lib/address/cash-address.spec.ts

@@ -163,6 +163,9 @@ test('encodeCashAddressFormat: works', (t) => {
 });
 
 test('encodeCashAddress: works', (t) => {
+  /**
+   * From `f85d4bd8a03ca106c9deb47b791803dac7f0333809e3f1dd04d182e0aba6e553`
+   */
   const payload = hexToBin('15d16c84669ab46059313bf0747e781f1d13936d');
   t.deepEqual(
     encodeCashAddress({

src/lib/engine/types/bcmr-types.ts

@@ -584,6 +584,8 @@ export type IdentitySnapshot = {
    * The split ID of this identity's chain of record.
    *
    * If undefined, defaults to {@link MetadataRegistry.defaultChain}.
+   *
+   * TODO: rename "splitId" to "chainBranchId" (more clearly refers to the immediate descendent of the split block)
    */
   splitId?: string;
 

src/lib/format/log.spec.ts

@@ -81,3 +81,5 @@ test('stringifyTestVector', (t) => {
     one,
   );
 });
+
+test.todo('elideWordsAtLength');

src/lib/format/log.ts

@@ -114,3 +114,37 @@ export const stringifyTestVector = (
     .replace(uint8ArrayRegex, "hexToBin('$1')")
     .replace(bigIntRegex, '$1n');
 };
+
+/**
+ * Elide words and hex strings in the given `text` at `maxLength`. Max length
+ * defaults to `148`, the maximum hex-encoded length (with `0x` prefix) of most
+ * ECDSA signatures.
+ *
+ * Hex strings include a count of total bytes, e.g.
+ * `0x01 … (512 total bytes) … 10101`. (Note that the surrounding spacing
+ * decreases the incidences of line breaks within the message.)
+ *
+ * @param text - the text to process
+ * @param maxLength - the maximum length of each word in the resulting text
+ * @returns
+ */
+export const elideWordsAndHexAtLength = (
+  text: string,
+  // eslint-disable-next-line @typescript-eslint/no-magic-numbers
+  maxLength = 148,
+) =>
+  text.replace(/\S+/gu, (w) => {
+    if (w.length < maxLength) return w;
+    const prefix = '0x'.length;
+    const byte = 2;
+    const match = /^(?:<)?(?<hex>0x[0-9A-Fa-f]+)(?:>)?$/gu.exec(w);
+    const middle = match
+      ? // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+        ` … (${(match.groups!['hex']!.length - prefix) / byte} total bytes) … `
+      : '…';
+    const keep = maxLength - middle.length;
+    const half = 2;
+    const front = Math.floor(keep / half);
+    const back = keep - front;
+    return `${w.slice(0, front)}${middle}${w.slice(w.length - back)}`;
+  });