remove bitly/attributions specific examples

Author: jakeheft

CMV_SUPPORT.md

@@ -1,10 +1,10 @@
 # CMV (Continuous Materialized View) Support for little_bigtable
 
-## Context
+## Overview
 
-The attributions app needs a CMV to re-key `attributions_conversion_events` data
-by `provider_id#client_id` for efficient shop-level queries. Production Bigtable
-handles this automatically, but the local emulator needs to support it for dev/testing.
+Bigtable CMVs allow you to re-key table data for efficient queries on alternate key orderings.
+Production Bigtable handles CMV maintenance automatically, but the local emulator needs explicit
+support for development and testing.
 
 ## Key Finding
 
@@ -25,18 +25,18 @@ Define CMVs in a JSON file:
 ```json
 [
   {
-    "source_table": "attributions_conversion_events",
-    "view_id": "attributions_conversion_events_by_client",
+    "source_table": "events",
+    "view_id": "events_by_account",
     "key_separator": "#",
     "key_mapping": [3, 4, 1, 2, 0],
-    "include_families": ["cr", "d", "m"],
+    "include_families": ["cf1", "cf2"],
     "append_source_key": true
   }
 ]
 ```
 
 - `source_table`: the table that feeds the CMV
-- `view_id`: the CMV name (used as the table name for reads)
+- `view_id`: the materialized view ID (used as the table name for reads)
 - `key_separator`: delimiter in the composite row key
 - `key_mapping`: 0-based indices into `SPLIT(source_key, separator)` in the new key order
 - `include_families`: column families to carry (empty = all)
@@ -47,7 +47,7 @@ Define CMVs in a JSON file:
 ```bash
 little_bigtable --host 0.0.0.0 --port 8300 \
   --db-file /data/little_bigtable/little_bigtable.db \
-  --cmv-config /path/to/attributions.json
+  --cmv-config ./cmv_configs/example.json
 ```
 
 ### 3. Write-time Sync
@@ -70,16 +70,16 @@ derives the CMV key and deletes the corresponding CMV row.
 Since the CMV shadow table is a regular table, reads use the standard approach:
 
 ```go
-table := client.Open("attributions_conversion_events_by_client")
-row, err := table.ReadRow(ctx, "shopify#myshop.myshopify.com#...")
+table := client.Open("events_by_account")
+row, err := table.ReadRow(ctx, "region_a#account_123#...")
 ```
 
 ## What's Changed
 
 ### New Files
 - `bttest/cmv.go` — CMV config types, JSON loader, SQL parser, key transformation logic
 - `bttest/cmv_test.go` — Tests for key transformation, write sync, delete propagation
-- `cmv_configs/attributions.json` — Example config for the attributions app
+- `cmv_configs/` — Example config files
 
 ### Modified Files
 - `little_bigtable.go` — Added `--cmv-config` flag, version bump to 0.2.0
@@ -98,21 +98,21 @@ row, err := table.ReadRow(ctx, "shopify#myshop.myshopify.com#...")
 - **Backfill**: If data exists in the source table before the CMV is registered,
   it won't be retroactively copied.
 
-## Example: Attributions Key Transformation
+## Example: Key Transformation
 
-Source row key format:
+Source row key format (5 components):
 ```
-bitlink_id#revTs#conversion_type#provider_id#client_id#attribution_source_id
+item_id#timestamp#type#region#account_id
 ```
 
 With `key_mapping: [3, 4, 1, 2, 0]` and `append_source_key: true`, a source key:
 ```
-bit.ly/123#9999999#lead#shopify#myshop#01HWXYZ
+item-abc#9999999#type-x#region-a#account-42
 ```
 Becomes CMV key:
 ```
-shopify#myshop#9999999#lead#bit.ly/123#bit.ly/123#9999999#lead#shopify#myshop#01HWXYZ
+region-a#account-42#9999999#type-x#item-abc#item-abc#9999999#type-x#region-a#account-42
 ```
 
-This matches the production CMV's `ORDER BY provider_id, client_id, rev_ts,
-event_category, bitlink_id, source_key`.
+The first 5 components are the re-ordered key (per `key_mapping`); the remainder is the
+full original source key appended due to `append_source_key: true`.

bttest/cmv_test.go

@@ -32,25 +32,23 @@ func newTestServerWithCMV(t *testing.T, configs []CMVConfig) *server {
 }
 
 func TestCMVTransformKey(t *testing.T) {
-	// Mirrors the production CMV config: key_mapping [3,4,1,2,0] + append_source_key.
-	//   SELECT SPLIT(_key,'#')[SAFE_OFFSET(3)] AS provider_id, ..., _key AS source_key
-	//   ORDER BY provider_id, client_id, rev_ts, event_category, bitlink_id, source_key
-	// CMV key = provider_id#client_id#rev_ts#event_category#bitlink_id#<full_source_key>
+	// key_mapping [3,4,1,2,0] + append_source_key:
+	// CMV key = parts[3]#parts[4]#parts[1]#parts[2]#parts[0]#<full_source_key>
 	inst := &cmvInstance{
 		config: CMVConfig{
-			SourceTable:     "attributions_conversion_events",
-			ViewID:          "attributions_conversion_events_by_client",
+			SourceTable:     "events",
+			ViewID:          "events_by_account",
 			KeySeparator:    "#",
 			KeyMapping:      []int{3, 4, 1, 2, 0},
 			AppendSourceKey: true,
 		},
 	}
 
-	sourceKey := "bitlink123#9999999999#order#shopify#myshop.myshopify.com#01HWXYZ"
+	sourceKey := "item-abc#9999999#type-x#region-a#account-42#src-01"
 	got := inst.transformKey(sourceKey)
-	// parts: [0]bitlink123 [1]9999999999 [2]order [3]shopify [4]myshop.myshopify.com [5]01HWXYZ
+	// parts: [0]item-abc [1]9999999 [2]type-x [3]region-a [4]account-42 [5]src-01
 	// mapped: parts[3]#parts[4]#parts[1]#parts[2]#parts[0] + full source key
-	want := "shopify#myshop.myshopify.com#9999999999#order#bitlink123#bitlink123#9999999999#order#shopify#myshop.myshopify.com#01HWXYZ"
+	want := "region-a#account-42#9999999#type-x#item-abc#item-abc#9999999#type-x#region-a#account-42#src-01"
 	assert.Equal(t, want, got)
 }
 
@@ -264,11 +262,11 @@ func TestLoadCMVConfigs(t *testing.T) {
 
 	content := `[
 		{
-			"source_table": "attributions_conversion_events",
-			"view_id": "attributions_conversion_events_by_client",
+			"source_table": "events",
+			"view_id": "events_by_account",
 			"key_separator": "#",
 			"key_mapping": [3, 4, 1, 2, 0],
-			"include_families": ["cr", "d", "m"],
+			"include_families": ["cf1", "cf2"],
 			"append_source_key": true
 		}
 	]`
@@ -279,40 +277,38 @@ func TestLoadCMVConfigs(t *testing.T) {
 	configs, err := LoadCMVConfigs(tmpFile.Name())
 	require.NoError(t, err)
 	require.Len(t, configs, 1)
-	assert.Equal(t, "attributions_conversion_events", configs[0].SourceTable)
-	assert.Equal(t, "attributions_conversion_events_by_client", configs[0].ViewID)
+	assert.Equal(t, "events", configs[0].SourceTable)
+	assert.Equal(t, "events_by_account", configs[0].ViewID)
 	assert.Equal(t, "#", configs[0].KeySeparator)
 	assert.Equal(t, []int{3, 4, 1, 2, 0}, configs[0].KeyMapping)
-	assert.Equal(t, []string{"cr", "d", "m"}, configs[0].IncludeFamilies)
+	assert.Equal(t, []string{"cf1", "cf2"}, configs[0].IncludeFamilies)
 	assert.True(t, configs[0].AppendSourceKey)
 }
 
 func TestParseCMVConfigFromSQL(t *testing.T) {
-	// Mirrors the production Terraform CMV SQL exactly: no CAST, _key aliased as
-	// source_key, attribution_source_id is embedded in source_key not a separate component.
+	// Standard Bigtable CMV SQL pattern: plain SPLIT (no CAST), _key aliased,
+	// alias appears in ORDER BY to set AppendSourceKey = true.
 	query := `SELECT
-  SPLIT(_key, '#')[SAFE_OFFSET(3)] AS provider_id,
-  SPLIT(_key, '#')[SAFE_OFFSET(4)] AS client_id,
-  SPLIT(_key, '#')[SAFE_OFFSET(1)] AS rev_ts,
-  SPLIT(_key, '#')[SAFE_OFFSET(2)] AS event_category,
-  SPLIT(_key, '#')[SAFE_OFFSET(0)] AS bitlink_id,
-  _key AS source_key,
-  cr AS cr,
-  d AS d,
-  m AS m
-FROM ` + "`attributions_conversion_events`" + `
-ORDER BY provider_id, client_id, rev_ts, event_category, bitlink_id, source_key`
-
-	cfg, err := ParseCMVConfigFromSQL("attributions_conversion_events_by_client", query)
+  SPLIT(_key, '#')[SAFE_OFFSET(3)] AS region,
+  SPLIT(_key, '#')[SAFE_OFFSET(4)] AS account_id,
+  SPLIT(_key, '#')[SAFE_OFFSET(1)] AS timestamp,
+  SPLIT(_key, '#')[SAFE_OFFSET(2)] AS type,
+  SPLIT(_key, '#')[SAFE_OFFSET(0)] AS item_id,
+  _key AS src_key,
+  cf1 AS cf1,
+  cf2 AS cf2
+FROM ` + "`events`" + `
+ORDER BY region, account_id, timestamp, type, item_id, src_key`
+
+	cfg, err := ParseCMVConfigFromSQL("events_by_account", query)
 	require.NoError(t, err)
-	assert.Equal(t, "attributions_conversion_events", cfg.SourceTable)
-	assert.Equal(t, "attributions_conversion_events_by_client", cfg.ViewID)
+	assert.Equal(t, "events", cfg.SourceTable)
+	assert.Equal(t, "events_by_account", cfg.ViewID)
 	assert.Equal(t, "#", cfg.KeySeparator)
 	assert.Equal(t, []int{3, 4, 1, 2, 0}, cfg.KeyMapping)
 	assert.True(t, cfg.AppendSourceKey)
-	assert.Contains(t, cfg.IncludeFamilies, "cr")
-	assert.Contains(t, cfg.IncludeFamilies, "d")
-	assert.Contains(t, cfg.IncludeFamilies, "m")
+	assert.Contains(t, cfg.IncludeFamilies, "cf1")
+	assert.Contains(t, cfg.IncludeFamilies, "cf2")
 }
 
 func TestCMVDropRowRangePrefix(t *testing.T) {

cmv_configs/attributions.json

@@ -0,0 +1,10 @@
+[
+  {
+    "source_table": "events",
+    "view_id": "events_by_account",
+    "key_separator": "#",
+    "key_mapping": [3, 4, 1, 2, 0],
+    "include_families": ["cf1", "cf2"],
+    "append_source_key": true
+  }
+]