Skip to content

locking to 5.6#79

Open
jamescyeh wants to merge 1 commit into
developfrom
feature/lock-to-5dot6
Open

locking to 5.6#79
jamescyeh wants to merge 1 commit into
developfrom
feature/lock-to-5dot6

Conversation

@jamescyeh

Copy link
Copy Markdown
Contributor

Some packages were requiring php 7.0

@gfronza gfronza left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SInCE SInCE self-requested a review January 4, 2019 12:43

@SInCE SInCE left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using "php": ">=5.6.0 || >=7.0", for the require statement it works fine for both platform versions, and doesn't require the hardcoded platform definition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants