Skip to content

fix: replace crypto.BinaryLike with Buffer in KeyUtils for @types/nod… #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aharoitx wants to merge 1 commit into
base: 8.0.x
Choose a base branch
from
+3 −3
Open

fix: replace crypto.BinaryLike with Buffer in KeyUtils for @types/nod… #354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/util/KeyUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export class KeyUtils {
}

public get_sin_from_key(kp: elliptic.ec.KeyPair): string {
const pk: crypto.BinaryLike = Buffer.from(kp.getPublic().encodeCompressed());
const pk: Buffer = Buffer.from(kp.getPublic().encodeCompressed());
const version: Buffer = this.get_version_from_compressed_key(pk);
const checksum: Buffer = this.get_checksum_from_version(version);
return bs58.encode(Buffer.concat([version, checksum]));
Expand All @@ -39,14 +39,14 @@ export class KeyUtils {
return ecKey.getPublic().encodeCompressed('hex');
}

private get_version_from_compressed_key(pk: crypto.BinaryLike): Buffer {
private get_version_from_compressed_key(pk: Buffer): Buffer {
const sh2 = crypto.createHash('sha256').update(pk).digest();
const rp = crypto.createHash('ripemd160').update(sh2).digest();

return Buffer.concat([Buffer.from('0F', 'hex'), Buffer.from('02', 'hex'), rp]);
}

private get_checksum_from_version(version: crypto.BinaryLike): Buffer {
private get_checksum_from_version(version: Buffer): Buffer {
const h1 = crypto.createHash('sha256').update(version).digest();
const h2 = crypto.createHash('sha256').update(h1).digest();

Expand Down