fix(target): treat dependencies and buildPhases as optional keys#331
Open
ataetgi wants to merge 1 commit into
Open
fix(target): treat dependencies and buildPhases as optional keys#331ataetgi wants to merge 1 commit into
ataetgi wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates Xcode target parsing to tolerate missing dependencies and buildPhases keys in serialized target objects instead of failing fast.
Changes:
- Treat
dependenciesas optional: ignore “key not found” errors while still failing on other errors. - Treat
buildPhasesas optional: ignore “key not found” errors while still failing on other errors.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Xcode 16.2+ omits the 'dependencies' key from project.pbxproj when a target has no dependencies (instead of writing 'dependencies = ();'). This causes parseTarget() to fail with a KeyNotFoundError. Apply the same IsKeyNotFoundError guard already used for 'productType' and 'productReference'. Also guard 'buildPhases' for forward compat. Fixes bitrise-io#330
ataetgi
force-pushed
the
fix/optional-dependencies-key
branch
from
467f27b to
8ad112c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Xcode 16.2+ omits the
dependencieskey fromproject.pbxprojwhen a target has no dependencies (instead of writingdependencies = ();). This causesparseTarget()to fail with aKeyNotFoundError.Changes
Apply the same
IsKeyNotFoundErrorguard already used forproductTypeandproductReferenceto:dependencies— fixes the immediate breakagebuildPhases— forward-compatibility (Xcode may optimize this away too)Testing
go test ./xcodeproject/xcodeproj/...)Fixes #330