Skip to content

fix(target): treat dependencies and buildPhases as optional keys #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ataetgi wants to merge 1 commit into
base: v1
Choose a base branch
from
Open

fix(target): treat dependencies and buildPhases as optional keys #331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions xcodeproject/xcodeproj/target.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,10 @@ func parseTarget(id string, objects serialized.Object) (Target, error) {

dependencyIDs, err := rawTarget.StringSlice("dependencies")
if err != nil {
return Target{}, err
if !serialized.IsKeyNotFoundError(err) {
return Target{}, err
}
Comment thread
ataetgi marked this conversation as resolved.
dependencyIDs = []string{}
}

var dependencies []TargetDependency
Expand Down Expand Up @@ -168,7 +171,10 @@ func parseTarget(id string, objects serialized.Object) (Target, error) {

buildPhaseIDs, err := rawTarget.StringSlice("buildPhases")
if err != nil {
return Target{}, err
if !serialized.IsKeyNotFoundError(err) {
return Target{}, err
}
buildPhaseIDs = []string{}
}
Comment thread
ataetgi marked this conversation as resolved.

return Target{
Expand Down