Skip to content

chore: migrate sliceutil v1 to v2 #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benbitrise wants to merge 3 commits into
base: master
Choose a base branch
from
Open

chore: migrate sliceutil v1 to v2 #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e716dd
chore: migrate sliceutil v1 to v2
benbitrise Apr 24, 2026
89aea5d
chore: bump go version to 1.21 for slices package compatibility
benbitrise Apr 24, 2026
20effc5
chore: run go mod tidy after go version bump
benbitrise Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gitclone/git.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ package gitclone
import (
"fmt"
"path/filepath"
"slices"
"strings"

"github.com/bitrise-io/go-utils/command/git"
"github.com/bitrise-io/go-utils/pathutil"
"github.com/bitrise-io/go-utils/sliceutil"
)

const (
Expand Down Expand Up @@ -193,7 +193,7 @@ func handleCheckoutError(callback getAvailableBranches, tag string, err error, s
branches := branchesByRemote[originRemoteName]
// There was no error grabbing the available branches
// And the current branch is not present in the list
if branchesErr == nil && !sliceutil.IsStringInSlice(branch, branches) {
if branchesErr == nil && !slices.Contains(branches, branch) {
return newStepErrorWithBranchRecommendations(
tag,
err,
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/bitrise-steplib/steps-git-clone

go 1.18
go 1.21

require (
github.com/bitrise-io/bitrise-init v0.0.0-20210518121553-1e678625c45d
Expand Down
46 changes: 0 additions & 46 deletions vendor/github.com/bitrise-io/go-utils/sliceutil/sliceutil.go
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion vendor/modules.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ github.com/bitrise-io/go-utils/parseutil
github.com/bitrise-io/go-utils/pathutil
github.com/bitrise-io/go-utils/pointers
github.com/bitrise-io/go-utils/retry
github.com/bitrise-io/go-utils/sliceutil
github.com/bitrise-io/go-utils/ziputil
# github.com/bitrise-io/go-utils/v2 v2.0.0-alpha.33
## explicit; go 1.17
Expand Down