Percentile Clipping causes FutureWarning

[Avelina9X]

When percentile clipping is set to a value below 100 it triggers a future warning as the underlying method used to calculate the clipping values has been marked as deprecated:

bitsandbytes/bitsandbytes/functional.py

Line 1395 in 14147f6

@deprecated("This function is deprecated and will be removed in a future release.", category=FutureWarning)

May I ask why this is? Is percentile clipping itself slated for removal?

[matthewdouglas]

Thanks for the feedback!

Yes, percentile clipping itself is deprecated. We could make this more clear with a warning in the optimizers. Setting block_wise=False is a similar situation where we have marked a function it uses as deprecated in bitsandbytes.functional but it may be more clear if we warned when initializing an optimizer with it.

[TimDettmers]

Closing this as resolved. As matthewdouglas confirmed, percentile clipping is deprecated, which is why the underlying function triggers a FutureWarning. This is by design. A clearer deprecation warning at optimizer initialization time would improve the UX, but the behavior is intentional.