Skip to content

update bnb log #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jiqing-feng wants to merge 8 commits into from
Closed

update bnb log #1661

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
343bfd5
update bnb log
jiqing-feng May 29, 2025
ccc645d
fix lib
jiqing-feng May 29, 2025
09ceea2
update warning
jiqing-feng May 30, 2025
e8d9883
Merge branch 'main' into log
jiqing-feng Jun 3, 2025
47539fa
add mock lib for xpu
jiqing-feng Jun 3, 2025
3fbc499
Merge branch 'main' into log
jiqing-feng Jun 4, 2025
f2e9d66
Merge branch 'main' into log
jiqing-feng Jun 5, 2025
bc4a540
update log
jiqing-feng Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion bitsandbytes/cextension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,16 @@ def get_native_library() -> BNBNativeLibrary:


try:
lib = get_native_library()
if hasattr(torch, "xpu") and torch.xpu.is_available():
if not (ipex_cpu or ipex_xpu):
logger.warning(
"Detected Intel XPU but no Intel Extension for PyTorch (IPEX) installed. "
"IPEX is recommended for Intel XPU support in bitsandbytes to get better performance. "
Copy link
Copy Markdown
Contributor

@Devjiu Devjiu May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please mention Triton here?
For example: "XPU is detected, but IPEX is missing, will try to use Trtiton implementation. If performance is lower your expectations, consider installing IPEX"

The current wording effectively prohibits the use of XPU without IPEX.

Copy link
Copy Markdown
Contributor Author

@jiqing-feng jiqing-feng May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

"Please check the installation doc to install `intel_extension_for_pytorch`. "
)
Comment on lines +303 to +305
Copy link
Copy Markdown
Member

@matthewdouglas matthewdouglas Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For most of our target audience I feel like this isn't going to be super informative. It's OK for now but eventually we might want to find a way to spell out exactly what it means for them, and whether we should be loud about it or not.

lib = ErrorHandlerMockBNBNativeLibrary("XPU does not need native library")
Copy link
Copy Markdown

@yao-matrix yao-matrix May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why need ErrorHandlerMockBNBNativeLibrary

Copy link
Copy Markdown
Contributor Author

@jiqing-feng jiqing-feng May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it was the default lib, but we can just set lib=None since XPU will not use lib.

else:
lib = get_native_library()
except Exception as e:
error_msg = str(e)
if not (ipex_cpu or ipex_xpu):
Expand Down