-
Notifications
You must be signed in to change notification settings - Fork 660
suggestion to add GRAPHENE_BLOCKCHAIN_NAME to config #1767
Copy link
Copy link
Open
Labels
1b User StoryThe User Story details a requirement. It may reference a parent Epic. It may reference child Task(s)The User Story details a requirement. It may reference a parent Epic. It may reference child Task(s)2a Discussion NeededPrompt for team to discuss at next stand up.Prompt for team to discuss at next stand up.3b FeatureClassification indicating the addition of novel functionality to the designClassification indicating the addition of novel functionality to the design4a Low PriorityPriority indicating minimal impact to system/user -OR- an inexpensive workaround existsPriority indicating minimal impact to system/user -OR- an inexpensive workaround exists6 APIImpact flag identifying the application programing interface (API)Impact flag identifying the application programing interface (API)6 CLIImpact flag identifying the command line interface (CLI) wallet applicationImpact flag identifying the command line interface (CLI) wallet application6 UXImpact flag identifying the User Interface (UX)Impact flag identifying the User Interface (UX)9b SmallEffort estimation indicating TBDEffort estimation indicating TBDgood first issue
Milestone
Metadata
Metadata
Assignees
Labels
1b User StoryThe User Story details a requirement. It may reference a parent Epic. It may reference child Task(s)The User Story details a requirement. It may reference a parent Epic. It may reference child Task(s)2a Discussion NeededPrompt for team to discuss at next stand up.Prompt for team to discuss at next stand up.3b FeatureClassification indicating the addition of novel functionality to the designClassification indicating the addition of novel functionality to the design4a Low PriorityPriority indicating minimal impact to system/user -OR- an inexpensive workaround existsPriority indicating minimal impact to system/user -OR- an inexpensive workaround exists6 APIImpact flag identifying the application programing interface (API)Impact flag identifying the application programing interface (API)6 CLIImpact flag identifying the command line interface (CLI) wallet applicationImpact flag identifying the command line interface (CLI) wallet application6 UXImpact flag identifying the User Interface (UX)Impact flag identifying the User Interface (UX)9b SmallEffort estimation indicating TBDEffort estimation indicating TBDgood first issue
Type
Fields
Give feedbackNo fields configured for issues without a type.
User Story
As a graphene fork and bitshares blockchain developer I want the name of the blockchain to be added to config so that client programs i write can display the info to their users.
Global var can be added at https://github.com/bitshares/bitshares-core/blob/master/libraries/chain/include/graphene/chain/config.hpp#L26 and displayed initially just in the
infowallet call at:https://github.com/bitshares/bitshares-core/blob/master/libraries/wallet/wallet.cpp#L548
I think this will be also be displayed automatically at https://github.com/bitshares/bitshares-core/blob/master/libraries/app/database_api.cpp#L623
Another spot can be as an initial title banner when witness node is started. Currently when the chain is new a banner "Welcome to graphene" is displayed. Displaying the blockchain name when chain is not new can be a good idea.
Looking for comments.
Impacts
Describe which portion(s) of BitShares Core may be impacted by your request. Please tick at least one box.