Simplify CardScanViewModel state and update flag key

Move hasHandledScan from Parcelable state to a private var since
it is internal bookkeeping, not UI state. Update flag key name to
pm-34171-card-scanner. Add OmitFromCoverage to navigation, fix
minor formatting.

Author: SaintPatrck

app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/cardscanner/CardScanNavigation.kt

@@ -1,14 +1,18 @@
+@file:OmitFromCoverage
+
 package com.x8bit.bitwarden.ui.vault.feature.cardscanner
 
 import androidx.navigation.NavController
 import androidx.navigation.NavGraphBuilder
 import androidx.navigation.NavOptions
+import com.bitwarden.annotation.OmitFromCoverage
 import com.bitwarden.ui.platform.base.util.composableWithSlideTransitions
 import kotlinx.serialization.Serializable
 
 /**
  * The type-safe route for the card scan screen.
  */
+@OmitFromCoverage
 @Serializable
 data object CardScanRoute
 

app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/cardscanner/CardScanScreen.kt

@@ -106,12 +106,7 @@ fun CardScanScreen(
                     modifier = Modifier
                         .weight(1f)
                         .fillMaxSize()
-                        .background(
-                            color = BitwardenTheme
-                                .colorScheme
-                                .background
-                                .scrim,
-                        )
+                        .background(color = BitwardenTheme.colorScheme.background.scrim)
                         .padding(horizontal = 16.dp),
                 ) {
                     Text(

app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/cardscanner/CardScanViewModel.kt

@@ -1,30 +1,26 @@
 package com.x8bit.bitwarden.ui.vault.feature.cardscanner
 
 import android.os.Parcelable
-import androidx.lifecycle.SavedStateHandle
 import com.bitwarden.ui.platform.base.BaseViewModel
 import com.bitwarden.ui.platform.base.DeferredBackgroundEvent
 import com.bitwarden.ui.platform.feature.cardscanner.manager.CardScanManager
 import com.bitwarden.ui.platform.feature.cardscanner.util.CardScanData
 import com.bitwarden.ui.platform.feature.cardscanner.util.CardScanResult
 import dagger.hilt.android.lifecycle.HiltViewModel
-import kotlinx.coroutines.flow.update
 import kotlinx.parcelize.Parcelize
 import javax.inject.Inject
 
-private const val KEY_STATE = "state"
-
 /**
  * Handles [CardScanAction] and launches [CardScanEvent] for the [CardScanScreen].
  */
 @HiltViewModel
 class CardScanViewModel @Inject constructor(
     private val cardScanManager: CardScanManager,
-    savedStateHandle: SavedStateHandle,
 ) : BaseViewModel<CardScanState, CardScanEvent, CardScanAction>(
-    initialState = savedStateHandle[KEY_STATE]
-        ?: CardScanState(hasHandledScan = false),
+    initialState = CardScanState,
 ) {
+    private var hasHandledScan = false
+
     override fun handleAction(action: CardScanAction) {
         when (action) {
             is CardScanAction.CloseClick -> handleCloseClick()
@@ -43,8 +39,8 @@ class CardScanViewModel @Inject constructor(
     }
 
     private fun handleCardScanReceive(action: CardScanAction.CardScanReceive) {
-        if (state.hasHandledScan) return
-        mutableStateFlow.update { it.copy(hasHandledScan = true) }
+        if (hasHandledScan) return
+        hasHandledScan = true
         cardScanManager.emitCardScanResult(
             CardScanResult.Success(cardScanData = action.cardScanData),
         )
@@ -91,6 +87,4 @@ sealed class CardScanAction {
  * Represents the state of the card scan screen.
  */
 @Parcelize
-data class CardScanState(
-    val hasHandledScan: Boolean,
-) : Parcelable
+data object CardScanState : Parcelable

app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/cardscanner/CardScanViewModelTest.kt

@@ -1,6 +1,5 @@
 package com.x8bit.bitwarden.ui.vault.feature.cardscanner
 
-import androidx.lifecycle.SavedStateHandle
 import app.cash.turbine.test
 import com.bitwarden.ui.platform.base.BaseViewModelTest
 import com.bitwarden.ui.platform.feature.cardscanner.manager.CardScanManager
@@ -88,27 +87,14 @@ class CardScanViewModelTest : BaseViewModelTest() {
         }
 
         verify(exactly = 1) { cardScanManager.emitCardScanResult(any()) }
-        assertEquals(
-            DEFAULT_STATE.copy(hasHandledScan = true),
-            viewModel.stateFlow.value,
-        )
     }
 
-    private fun createViewModel(
-        initialState: CardScanState? = null,
-    ): CardScanViewModel =
+    private fun createViewModel(): CardScanViewModel =
         CardScanViewModel(
-            savedStateHandle = SavedStateHandle().apply {
-                set("state", initialState)
-            },
             cardScanManager = cardScanManager,
         )
 }
 
-private val DEFAULT_STATE = CardScanState(
-    hasHandledScan = false,
-)
-
 private val CARD_SCAN_DATA = CardScanData(
     number = "4111111111111111",
     expirationMonth = "12",

core/src/main/kotlin/com/bitwarden/core/data/manager/model/FlagKey.kt

@@ -114,7 +114,7 @@ sealed class FlagKey<out T : Any> {
      * Data object holding the feature flag key for the card scanner feature.
      */
     data object CardScanner : FlagKey<Boolean>() {
-        override val keyName: String = "card-scanner-mobile"
+        override val keyName: String = "pm-34171-card-scanner"
         override val defaultValue: Boolean = false
     }