Address code review feedback for card scan screen

Remove stale cardholderName parameter from test data, simplify
ScanError verify to use direct value instead of match lambda,
and fix import ordering.

Author: SaintPatrck

app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/composition/LocalManagerProvider.kt

@@ -22,9 +22,9 @@ import com.bitwarden.cxf.ui.composition.LocalCredentialExchangeImporter
 import com.bitwarden.cxf.ui.composition.LocalCredentialExchangeRequestValidator
 import com.bitwarden.cxf.validator.CredentialExchangeRequestValidator
 import com.bitwarden.cxf.validator.dsl.credentialExchangeRequestValidator
+import com.bitwarden.ui.platform.composition.LocalCardTextAnalyzer
 import com.bitwarden.ui.platform.composition.LocalExitManager
 import com.bitwarden.ui.platform.composition.LocalIntentManager
-import com.bitwarden.ui.platform.composition.LocalCardTextAnalyzer
 import com.bitwarden.ui.platform.composition.LocalQrCodeAnalyzer
 import com.bitwarden.ui.platform.feature.cardscanner.util.CardDataParser
 import com.bitwarden.ui.platform.feature.cardscanner.util.CardDataParserImpl

app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/cardscanner/CardScanViewModel.kt

@@ -4,8 +4,8 @@ import android.os.Parcelable
 import androidx.lifecycle.SavedStateHandle
 import com.bitwarden.ui.platform.base.BaseViewModel
 import com.bitwarden.ui.platform.base.DeferredBackgroundEvent
-import com.bitwarden.ui.platform.feature.cardscanner.util.CardScanData
 import com.bitwarden.ui.platform.feature.cardscanner.manager.CardScanManager
+import com.bitwarden.ui.platform.feature.cardscanner.util.CardScanData
 import com.bitwarden.ui.platform.feature.cardscanner.util.CardScanResult
 import dagger.hilt.android.lifecycle.HiltViewModel
 import kotlinx.coroutines.flow.update

app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/cardscanner/CardScanViewModelTest.kt

@@ -3,8 +3,8 @@ package com.x8bit.bitwarden.ui.vault.feature.cardscanner
 import androidx.lifecycle.SavedStateHandle
 import app.cash.turbine.test
 import com.bitwarden.ui.platform.base.BaseViewModelTest
-import com.bitwarden.ui.platform.feature.cardscanner.util.CardScanData
 import com.bitwarden.ui.platform.feature.cardscanner.manager.CardScanManager
+import com.bitwarden.ui.platform.feature.cardscanner.util.CardScanData
 import com.bitwarden.ui.platform.feature.cardscanner.util.CardScanResult
 import io.mockk.every
 import io.mockk.just
@@ -41,9 +41,7 @@ class CardScanViewModelTest : BaseViewModelTest() {
         }
 
         verify(exactly = 1) {
-            cardScanManager.emitCardScanResult(
-                match { it is CardScanResult.ScanError },
-            )
+            cardScanManager.emitCardScanResult(CardScanResult.ScanError())
         }
     }
 
@@ -115,6 +113,5 @@ private val CARD_SCAN_DATA = CardScanData(
     number = "4111111111111111",
     expirationMonth = "12",
     expirationYear = "2025",
-    cardholderName = "JOHN DOE",
     securityCode = "123",
 )

ui/src/test/kotlin/com/bitwarden/ui/platform/feature/cardscanner/manager/CardScanManagerTest.kt

@@ -20,7 +20,6 @@ class CardScanManagerTest {
                         number = "4111111111111111",
                         expirationMonth = "12",
                         expirationYear = "2025",
-                        cardholderName = "JOHN DOE",
                         securityCode = "123",
                     ),
                 )