Skip to content

Commit a58b58c

Browse files
committed
Remove Closeable implementation from CardTextAnalyzerImpl
LocalComposition doesn't provide a lifecycle hook for cleanup, so close() would never be invoked. Removes Closeable to stay consistent with QrCodeAnalyzerImpl.
1 parent dca5681 commit a58b58c

1 file changed

Lines changed: 1 addition & 7 deletions

File tree

ui/src/main/kotlin/com/bitwarden/ui/platform/feature/cardscanner/util/CardTextAnalyzerImpl.kt

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import com.bitwarden.annotation.OmitFromCoverage
77
import com.google.mlkit.vision.common.InputImage
88
import com.google.mlkit.vision.text.TextRecognition
99
import com.google.mlkit.vision.text.latin.TextRecognizerOptions
10-
import java.io.Closeable
1110
import java.util.concurrent.atomic.AtomicBoolean
1211

1312
/**
@@ -20,8 +19,7 @@ import java.util.concurrent.atomic.AtomicBoolean
2019
@OmitFromCoverage
2120
class CardTextAnalyzerImpl(
2221
private val cardDataParser: CardDataParser,
23-
) : CardTextAnalyzer,
24-
Closeable {
22+
) : CardTextAnalyzer {
2523

2624
private val isInAnalysis = AtomicBoolean(false)
2725

@@ -31,10 +29,6 @@ class CardTextAnalyzerImpl(
3129

3230
override lateinit var onCardScanned: (CardScanData) -> Unit
3331

34-
override fun close() {
35-
recognizer.close()
36-
}
37-
3832
@OptIn(ExperimentalGetImage::class)
3933
override fun analyze(image: ImageProxy) {
4034
if (!isInAnalysis.compareAndSet(false, true)) {

0 commit comments

Comments
 (0)