PM-39006: Bug: Update the setPassword flow for TDE users#7056
Merged
Conversation
Contributor
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed the TDE Code Review DetailsNo blocking findings. Notes considered and cleared during review:
|
d37fefc to
7ed2f16
Compare
Collaborator
Author
|
Thanks @aj-rosado |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-39006
📔 Objective
This PR address some issues in the setPassword flow for TDE user.
Main changes:
setPasswordfunction in auserStateTransactionto ensure no state-based navigation occurs when processing the change.MasterPasswordUnlockDatais set before trying to unlock the vault, that data is now required.ForcePasswordResetReasonon sync in order to ensure the correct flow is followed.